commit ccf12d213c95201a14f7d7014076af6162c6e995
author Vernon Mauery <vernon.mauery@linux.intel.com> Thu Feb 06 13:25:08 2020 -0800
committer Vernon Mauery <vernon.mauery@linux.intel.com> Thu Feb 06 13:35:26 2020 -0800
tree 906f8ed09c728e7157a21435f3f9db75458bdc0c
parent e9f8857a66c5df61a4e795a7d71b035fd89b92ef

Remove useless wildcard handlers

The default action is to return Command Not Found, which is exactly what
the wildcard handlers are doing. This just removes that extra code that
is not needed.

Change-Id: I0a25153395858efcdf56384ececaabc7eaf4e1af
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

chassishandler.cpp

diff --git a/chassishandler.cpp b/chassishandler.cpp
index 0326806..6e1341c 100644
--- a/chassishandler.cpp
+++ b/chassishandler.cpp
@@ -497,18 +497,6 @@
     return std::get<uint32_t>(propValue);
 }
 
-ipmi_ret_t ipmi_chassis_wildcard(ipmi_netfn_t netfn, ipmi_cmd_t cmd,
-                                 ipmi_request_t request,
-                                 ipmi_response_t response,
-                                 ipmi_data_len_t data_len,
-                                 ipmi_context_t context)
-{
-    // Status code.
-    ipmi_ret_t rc = IPMI_CC_INVALID;
-    *data_len = 0;
-    return rc;
-}
-
 /** @brief Implements the get chassis capabilities command
  *
  *  @returns IPMI completion code plus response data
@@ -1824,10 +1812,6 @@
 {
     createIdentifyTimer();
 
-    // <Wildcard Command>
-    ipmi_register_callback(NETFUN_CHASSIS, IPMI_CMD_WILDCARD, NULL,
-                           ipmi_chassis_wildcard, PRIVILEGE_USER);
-
     // Get Chassis Capabilities
     ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnChassis,
                           ipmi::chassis::cmdGetChassisCapabilities,

sensorhandler.cpp

diff --git a/sensorhandler.cpp b/sensorhandler.cpp
index e664441..1cffd55 100644
--- a/sensorhandler.cpp
+++ b/sensorhandler.cpp
@@ -601,18 +601,6 @@
                                  resp.upperNonRecoverable);
 }
 
-ipmi_ret_t ipmi_sen_wildcard(ipmi_netfn_t netfn, ipmi_cmd_t cmd,
-                             ipmi_request_t request, ipmi_response_t response,
-                             ipmi_data_len_t data_len, ipmi_context_t context)
-{
-    ipmi_ret_t rc = IPMI_CC_INVALID;
-
-    printf("IPMI S/E Wildcard Netfn:[0x%X], Cmd:[0x%X]\n", netfn, cmd);
-    *data_len = 0;
-
-    return rc;
-}
-
 /** @brief implements the get SDR Info command
  *  @param count - Operation
  *
@@ -1106,10 +1094,6 @@
 
 void register_netfn_sen_functions()
 {
-    // <Wildcard Command>
-    ipmi_register_callback(NETFUN_SENSOR, IPMI_CMD_WILDCARD, nullptr,
-                           ipmi_sen_wildcard, PRIVILEGE_USER);
-
     // <Platform Event Message>
     ipmi_register_callback(NETFUN_SENSOR, IPMI_CMD_PLATFORM_EVENT, nullptr,
                            ipmicmdPlatformEvent, PRIVILEGE_OPERATOR);

storagehandler.cpp

diff --git a/storagehandler.cpp b/storagehandler.cpp
index d2bc8a5..5b9726a 100644
--- a/storagehandler.cpp
+++ b/storagehandler.cpp
@@ -76,18 +76,6 @@
     words  ///< Device is accessed by words
 };
 
-ipmi_ret_t ipmi_storage_wildcard(ipmi_netfn_t netfn, ipmi_cmd_t cmd,
-                                 ipmi_request_t request,
-                                 ipmi_response_t response,
-                                 ipmi_data_len_t data_len,
-                                 ipmi_context_t context)
-{
-    // Status code.
-    ipmi_ret_t rc = IPMI_CC_INVALID;
-    *data_len = 0;
-    return rc;
-}
-
 /** @brief implements the get SEL Info command
  *  @returns IPMI completion code plus response data
  *   - selVersion - SEL revision
@@ -744,10 +732,6 @@
 
 void register_netfn_storage_functions()
 {
-    // <Wildcard Command>
-    ipmi_register_callback(NETFUN_STORAGE, IPMI_CMD_WILDCARD, NULL,
-                           ipmi_storage_wildcard, PRIVILEGE_USER);
-
     // <Get SEL Info>
     ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnStorage,
                           ipmi::storage::cmdGetSelInfo, ipmi::Privilege::User,