Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / d05b9dd8d56f6337839c0a896753940d543e975a
commitd05b9dd8d56f6337839c0a896753940d543e975a[log] [tgz]
authorJian Zhang <zhangjian.3032@bytedance.com>Tue Jul 04 14:48:40 2023 +0800
committerJian Zhang <zhangjian.3032@bytedance.com>Tue Jul 04 19:08:57 2023 +0800
tree624eeb49b55dee291c4151dad8d53a8fee790073
parent127a24bfd495e610502f1fed30c0f9810d0a73fb [diff]
fix set ipv4 netmask failed

Before `createIfAddr`, we accept the address is nullopt when set the
ipv4 netmask,

so, if the address is not null, check the address is `0.0.0.0`,
if null, use the `ifaddr->address`.

Tested:
1. Set netmask.
~# ipmitool lan set 1 netmask 255.255.255.0

2. Check the netmask.
~# ipmitool lan print 1 | grep -i sub
Subnet Mask             : 255.255.255.0

Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
Change-Id: I7b5967cb8c00bc9a1507c04df06e7898478b079f
1 file changed
tree: 624eeb49b55dee291c4151dad8d53a8fee790073
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. error-HostEvent.hpp
  25. fruread.hpp
  26. generate_whitelist.sh
  27. generate_whitelist_create.sh
  28. globalhandler.cpp
  29. globalhandler.hpp
  30. groupext.cpp
  31. host-cmd-manager.cpp
  32. host-cmd-manager.hpp
  33. host-interface.cpp
  34. host-interface.hpp
  35. host-ipmid-whitelist.conf
  36. ipmi_fru_info_area.cpp
  37. ipmi_fru_info_area.hpp
  38. ipmid-new.cpp
  39. ipmisensor.cpp
  40. ipmiwhitelist.hpp
  41. LICENSE
  42. meson.build
  43. meson_options.txt
  44. OWNERS
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. selutility.cpp
  49. selutility.hpp
  50. sensordatahandler.cpp
  51. sensordatahandler.hpp
  52. sensorhandler.cpp
  53. sensorhandler.hpp
  54. settings.cpp
  55. settings.hpp
  56. storageaddsel.cpp
  57. storageaddsel.hpp
  58. storagehandler.cpp
  59. storagehandler.hpp
  60. sys_info_param.cpp
  61. sys_info_param.hpp
  62. systemintfcmds.cpp
  63. systemintfcmds.hpp
  64. testaddsel.cpp
  65. testit.cpp
  66. transporthandler.cpp
  67. transporthandler.hpp
  68. whitelist-filter.cpp
README.md

Compile ipmid with default options:

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults:

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report:

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage