Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 32aece1a17c4553a2da324a8f0b2a3572ff2033a
commit32aece1a17c4553a2da324a8f0b2a3572ff2033a[log] [tgz]
authorPatrick Williams <patrick@stwcx.xyz>Fri Jan 24 10:06:55 2025 -0500
committerPatrick Williams <patrick@stwcx.xyz>Fri Jan 24 10:07:42 2025 -0500
treee58a27856288323a02acd1c9a27e66f7e9c15d3f
parentf62ad6fc53bbc38e5ce27b8b43c35324191bb4b7 [diff]
storagehandler: fix compile without open-power

When the `open-power` meson option is disabled, the code fails with
the following compile failure:

```
../storagehandler.cpp: In function ‘ipmi::RspType<short unsigned int> ipmiStorageAddSEL(uint16_t, uint8_t, uint32_t, uint16_t, uint8_t, uint8_t, uint8_t, uint8_t, std::array<unsigned char, 3>)’:
../storagehandler.cpp:685:27: error: unused variable ‘procedureType’ [-Werror=unused-variable]
  685 |     static constexpr auto procedureType = 0xDE;
      |                           ^~~~~~~~~~~~~
../storagehandler.cpp:677:64: error: unused parameter ‘sensorType’ [-Werror=unused-parameter]
  677 |                       [[maybe_unused]] uint8_t evmRev, uint8_t sensorType,
```

Add trivial changes to fix.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia7cc8dab700381c78461899bfc8c33d43cab3625
1 file changed
tree: e58a27856288323a02acd1c9a27e66f7e9c15d3f
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. error-HostEvent.hpp
  24. fruread.hpp
  25. generate_whitelist.sh
  26. generate_whitelist_create.sh
  27. globalhandler.cpp
  28. globalhandler.hpp
  29. groupext.cpp
  30. host-cmd-manager.cpp
  31. host-cmd-manager.hpp
  32. host-interface.cpp
  33. host-interface.hpp
  34. host-ipmid-whitelist.conf
  35. ipmi_fru_info_area.cpp
  36. ipmi_fru_info_area.hpp
  37. ipmiallowlist.hpp
  38. ipmid-new.cpp
  39. ipmisensor.cpp
  40. LICENSE
  41. meson.build
  42. meson.options
  43. OWNERS
  44. read_fru_data.cpp
  45. read_fru_data.hpp
  46. README.md
  47. selutility.cpp
  48. selutility.hpp
  49. sensordatahandler.cpp
  50. sensordatahandler.hpp
  51. sensorhandler.cpp
  52. sensorhandler.hpp
  53. settings.cpp
  54. settings.hpp
  55. storageaddsel.cpp
  56. storageaddsel.hpp
  57. storagehandler.cpp
  58. storagehandler.hpp
  59. sys_info_param.cpp
  60. sys_info_param.hpp
  61. systemintfcmds.cpp
  62. systemintfcmds.hpp
  63. transportconstants.hpp
  64. transporthandler.cpp
  65. transporthandler.hpp
  66. whitelist-filter.cpp
README.md

phosphor-host-ipmid

Compile ipmid with default options

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage