Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / b99de182fa868d7adb07e95d4603706e31f84abd
commitb99de182fa868d7adb07e95d4603706e31f84abd[log] [tgz]
authorJohnathan Mantey <johnathanx.mantey@intel.com>Thu Dec 21 08:28:18 2023 -0800
committerJohnathan Mantey <johnathanx.mantey@intel.com>Thu Feb 22 16:35:56 2024 +0000
treec40061a5c313be91f701b7db8153d2a3a87c6b1b
parentf027bf0334b91de5c829d21082dd42b75b45a405 [diff]
Assign ASCII-Latin8 to dbus-sdr FRU string Type/Len

The FRU ID string Type/Len encoding in the dbus-sdr code is left
unassigned, which causes it to be tagged as unicode characters. This
is not the encoding of the data, which is actually ASCII/Latin8.

The problem appears to go unnoticed, I expect, because the dbus-sdr
functionality is not enabled. When dbus-sdr is enabled the id-string
supplied to IPMITool is ASCII/Latin8, but IPMITool decodes it as
unicode.

Tested:
Enabled dbus-sdr features.
Use 'ipmitool fru print'
Confirm FRU id-strings print as ASCII/Latin8

Change-Id: Ie6d936f6b5a0b0cd9ccd9adb68e46e1efbb9b2e5
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
1 file changed
tree: c40061a5c313be91f701b7db8153d2a3a87c6b1b
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. error-HostEvent.hpp
  24. fruread.hpp
  25. generate_whitelist.sh
  26. generate_whitelist_create.sh
  27. globalhandler.cpp
  28. globalhandler.hpp
  29. groupext.cpp
  30. host-cmd-manager.cpp
  31. host-cmd-manager.hpp
  32. host-interface.cpp
  33. host-interface.hpp
  34. host-ipmid-whitelist.conf
  35. ipmi_fru_info_area.cpp
  36. ipmi_fru_info_area.hpp
  37. ipmiallowlist.hpp
  38. ipmid-new.cpp
  39. ipmisensor.cpp
  40. LICENSE
  41. meson.build
  42. meson.options
  43. OWNERS
  44. read_fru_data.cpp
  45. read_fru_data.hpp
  46. README.md
  47. selutility.cpp
  48. selutility.hpp
  49. sensordatahandler.cpp
  50. sensordatahandler.hpp
  51. sensorhandler.cpp
  52. sensorhandler.hpp
  53. settings.cpp
  54. settings.hpp
  55. storageaddsel.cpp
  56. storageaddsel.hpp
  57. storagehandler.cpp
  58. storagehandler.hpp
  59. sys_info_param.cpp
  60. sys_info_param.hpp
  61. systemintfcmds.cpp
  62. systemintfcmds.hpp
  63. transportconstants.hpp
  64. transporthandler.cpp
  65. transporthandler.hpp
  66. whitelist-filter.cpp
README.md

Compile ipmid with default options:

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults:

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report:

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage