commit dbf66e1b49603a51c128e941d18759856d220bcf
author Thang Tran <thuutran@amperecomputing.com> Thu Sep 21 13:07:24 2023 +0700
committer Thang Tran <thuutran@amperecomputing.com> Mon Nov 06 02:30:44 2023 +0000
tree 8a428849dc9db188b34725bba82fc406c7ca78dc
parent 57f4941c2c4863f235fc229fa1988a3b02557a58

dbus-sdr: remove redundant Get/Set SEL time commands

In the dbus-sdr, the Set SEL time command is not implemented, it is an
dummy function. Beside that the Get SEL command does not refer to dbus
interface to get the SEL time, it is geting directly from hardware.

Both Set/Get SEL time commands are implemented in storagehandler.cpp
file, therefore, we should remove redundant commands in the dbus-sdr.

Tested:
     1. Disable NTP
        $timedatectl set-ntp false
     2. Request to Set SEL time
        $ipmitool sel time set "12/31/2020 12:00:00"
         12/31/20 00:00:00 UTC
     3. Request to Get SEL time
        $ipmitool sel time get
         12/31/20 00:00:03 UTC

Change-Id: I8545d4a604c2f01f5c771be99cff9a638d08d54d
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

dbus-sdr/storagecommands.cpp

diff --git a/dbus-sdr/storagecommands.cpp b/dbus-sdr/storagecommands.cpp
index e784f7e..40deb1b 100644
--- a/dbus-sdr/storagecommands.cpp
+++ b/dbus-sdr/storagecommands.cpp
@@ -1148,24 +1148,6 @@
     return ipmi::responseSuccess(ipmi::sel::eraseComplete);
 }
 
-ipmi::RspType<uint32_t> ipmiStorageGetSELTime()
-{
-    struct timespec selTime = {};
-
-    if (clock_gettime(CLOCK_REALTIME, &selTime) < 0)
-    {
-        return ipmi::responseUnspecifiedError();
-    }
-
-    return ipmi::responseSuccess(selTime.tv_sec);
-}
-
-ipmi::RspType<> ipmiStorageSetSELTime(uint32_t)
-{
-    // Set SEL Time is not supported
-    return ipmi::responseInvalidCommand();
-}
-
 std::vector<uint8_t>
     getType8SDRs(ipmi::sensor::EntityInfoMap::const_iterator& entity,
                  uint16_t recordId)
@@ -1265,16 +1247,6 @@
     ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnStorage,
                           ipmi::storage::cmdClearSel, ipmi::Privilege::Operator,
                           ipmiStorageClearSEL);
-
-    // <Get SEL Time>
-    ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnStorage,
-                          ipmi::storage::cmdGetSelTime, ipmi::Privilege::User,
-                          ipmiStorageGetSELTime);
-
-    // <Set SEL Time>
-    ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnStorage,
-                          ipmi::storage::cmdSetSelTime,
-                          ipmi::Privilege::Operator, ipmiStorageSetSELTime);
 }
 } // namespace storage
 } // namespace ipmi

storagehandler.cpp

diff --git a/storagehandler.cpp b/storagehandler.cpp
index 0057b77..4c02a50 100644
--- a/storagehandler.cpp
+++ b/storagehandler.cpp
@@ -892,16 +892,6 @@
                           ipmi::storage::cmdGetSelInfo, ipmi::Privilege::User,
                           ipmiStorageGetSelInfo);
 
-    // <Get SEL Time>
-    ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnStorage,
-                          ipmi::storage::cmdGetSelTime, ipmi::Privilege::User,
-                          ipmiStorageGetSelTime);
-
-    // <Set SEL Time>
-    ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnStorage,
-                          ipmi::storage::cmdSetSelTime,
-                          ipmi::Privilege::Operator, ipmiStorageSetSelTime);
-
     // <Get SEL Timezone>
     ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnStorage,
                           ipmi::storage::cmdGetSelTimeUtcOffset,
@@ -962,6 +952,16 @@
                           ipmi::storage::cmdReserveSel, ipmi::Privilege::User,
                           ipmiStorageReserveSel);
 
+    // <Get SEL Time>
+    ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnStorage,
+                          ipmi::storage::cmdGetSelTime, ipmi::Privilege::User,
+                          ipmiStorageGetSelTime);
+
+    // <Set SEL Time>
+    ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnStorage,
+                          ipmi::storage::cmdSetSelTime,
+                          ipmi::Privilege::Operator, ipmiStorageSetSelTime);
+
     ipmi::fru::registerCallbackHandler();
     return;
 }