Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 7d5f481a3628c046d8328d7af0de122a0ed4c5e1
commit7d5f481a3628c046d8328d7af0de122a0ed4c5e1[log] [tgz]
authorJian <zhangjian.3032@bytedance.com>Wed Feb 23 19:30:27 2022 +0800
committerVernon Mauery <vernon.mauery@linux.intel.com>Fri Mar 04 22:19:17 2022 +0000
tree19f766433c5e091aeaa6b1e464b62e3f7fa5d787
parentd7c260173af9b863731b348e65d0c69cce3c179f [diff]
storagehandler: Fix deleteSELEntry() with 0x0000 and 0xFFFF ID

Fixed DeleteSelEntry command return unspecific error when
record ID is 0x0000 or 0xFFFF.

In IPMI spec 2.0 DeleteSelEntry command, the record ID 0x0000
and 0xFFFF means delete the first and last sel. But the code
does not delete the sel entry in this case.

Tested:
1. Get current Sel list.
    eg: ipmitool sel list, the response as below:
    1 | 02/24/2022 | 07:38:42 | Voltage #0x1c | Lower Critical going low  | Asserted
    2 | 02/24/2022 | 07:38:42 | System Boot Initiated #0xa6 | Initiated by power up | Asserted
    3 | 02/24/2022 | 07:38:42 | Voltage #0x1c | Lower Non-critical going low  | Asserted
    4 | 02/24/2022 | 07:38:43 | Voltage #0x1c | Lower Critical going low  | Asserted

2. Use DeleteSelEntry command, record ID is 0x0000, means remove the first entry.
    eg: ipmitool sel delete 0x0000, the response as below:
    Deleted entry 0

3. Check current sel list.
    eg: ipmitool sel list, the first sel entry has been deleted.
    2 | 02/24/2022 | 07:38:42 | System Boot Initiated #0xa6 | Initiated by power up | Asserted
    3 | 02/24/2022 | 07:38:42 | Voltage #0x1c | Lower Non-critical going low  | Asserted
    4 | 02/24/2022 | 07:38:43 | Voltage #0x1c | Lower Critical going low  | Asserted

4. Use DeleteSelEntry command, record ID is 0xFFFF, means remove the last entry.
    eg: ipmitool sel delete 0xFFFF, the response as below:
    Deleted entry 65535

5. Check current sel list.
    eg: ipmitool sel list, the last sel entry has been deleted.
    2 | 02/24/2022 | 07:38:42 | System Boot Initiated #0xa6 | Initiated by power up | Asserted
    3 | 02/24/2022 | 07:38:42 | Voltage #0x1c | Lower Non-critical going low  | Asserted

Change-Id: Iff13429e276c035c1d5ebc2f75a4c7ca9209d6d8
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
1 file changed
tree: 19f766433c5e091aeaa6b1e464b62e3f7fa5d787
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. OWNERS
  48. read_fru_data.cpp
  49. read_fru_data.hpp
  50. README.md
  51. sample.cpp
  52. sample.h
  53. selutility.cpp
  54. selutility.hpp
  55. sensordatahandler.cpp
  56. sensordatahandler.hpp
  57. sensorhandler.cpp
  58. sensorhandler.hpp
  59. settings.cpp
  60. settings.hpp
  61. storageaddsel.cpp
  62. storageaddsel.hpp
  63. storagehandler.cpp
  64. storagehandler.hpp
  65. sys_info_param.cpp
  66. sys_info_param.hpp
  67. systemintfcmds.cpp
  68. systemintfcmds.hpp
  69. testaddsel.cpp
  70. testit.cpp
  71. transporthandler.cpp
  72. transporthandler.hpp
  73. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.