Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / e73d15d5f5ea12ff94afb77c1e7f1867bd4c5acf
commite73d15d5f5ea12ff94afb77c1e7f1867bd4c5acf[log] [tgz]
authorWilliam A. Kennington III <wak@google.com>Wed Jan 24 15:12:21 2018 -0800
committerTom Joseph <tomjoseph@in.ibm.com>Mon Jan 29 11:42:49 2018 +0000
tree0f9f26112f8946d235a7a745bfe40e9641ecb9c1
parent3b76e3756edf54ece1b4059d193b65bb2769d22e [diff]
watchdog: Fix enabled value type

When deserializing a bool with sd_bus_message_read, it expects the
storage of the passed in container to be 4 bytes. A bool is not
guaranteed to be this large and will cause sd_bus_message_read to
scribble on the stack. Change enabled to int to guarantee enough
space to deserialize the result.

For reference libsystemd is doing:
  *(int*) p = !!*(uint8_t*) q;

Change-Id: Ic299e303fcb70941757c453a7b4f643337220afb
Signed-off-by: William A. Kennington III <wak@google.com>
1 file changed
tree: 0f9f26112f8946d235a7a745bfe40e9641ecb9c1
  1. app/
  2. docs/
  3. host-ipmid/
  4. scripts/
  5. softoff/
  6. test/
  7. xyz/
  8. .build.sh
  9. .gitignore
  10. .travis.yml
  11. apphandler.cpp
  12. apphandler.h
  13. bootstrap.sh
  14. chassishandler.cpp
  15. chassishandler.h
  16. configure.ac
  17. dcmihandler.cpp
  18. dcmihandler.hpp
  19. elog-errors.hpp
  20. error-HostEvent.hpp
  21. fruread.hpp
  22. generate_whitelist.sh
  23. globalhandler.cpp
  24. globalhandler.h
  25. groupext.cpp
  26. host-cmd-manager.cpp
  27. host-cmd-manager.hpp
  28. host-interface.cpp
  29. host-interface.hpp
  30. host-ipmid-whitelist.conf
  31. ipmi_fru_info_area.cpp
  32. ipmi_fru_info_area.hpp
  33. ipmid.cpp
  34. ipmid.hpp
  35. ipmisensor.cpp
  36. ipmiwhitelist.hpp
  37. LICENSE
  38. Makefile.am
  39. net.cpp
  40. net.hpp
  41. read_fru_data.cpp
  42. read_fru_data.hpp
  43. README.md
  44. sample.cpp
  45. sample.h
  46. selutility.cpp
  47. selutility.hpp
  48. sensordatahandler.cpp
  49. sensordatahandler.hpp
  50. sensorhandler.cpp
  51. sensorhandler.h
  52. settings.cpp
  53. settings.hpp
  54. storageaddsel.cpp
  55. storageaddsel.h
  56. storagehandler.cpp
  57. storagehandler.h
  58. systemintfcmds.cpp
  59. systemintfcmds.h
  60. testaddsel.cpp
  61. testit.cpp
  62. timer.cpp
  63. timer.hpp
  64. transporthandler.cpp
  65. transporthandler.hpp
  66. types.hpp
  67. utils.cpp
  68. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To full clean the repository again run ./bootstrap.sh clean.