commit e9e99d9321a4f1e2f776ef94c646ef15709e7551
author anil kumar appana <anil.kumarx.appana@intel.com> Sun Apr 28 23:47:24 2019 +0000
committer Vernon Mauery <vernon.mauery@linux.intel.com> Tue May 07 15:22:40 2019 +0000
tree 9b0515480c25b00114c5c586719a85a682facb5f
parent 4a5a99afa5575ef5f5a12510f1051a6c5977f2a8

globalhandler: move cold & warm reset to new API

Rewritten "cold & warm reset" command to use the newly
introduced IPMI provider API.

Tested:
verified ipmitool cold reset and warm reset commands

ipmitool raw 6 2 //cold reset command
system reboots

ipmitool raw 6 3 //warm reset command
system reboots

Change-Id: I4638fffe33deb1c97f51f97c8f09fef6a8688fba
Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

globalhandler.cpp

diff --git a/globalhandler.cpp b/globalhandler.cpp
index 27409c2..f6b24ac 100644
--- a/globalhandler.cpp
+++ b/globalhandler.cpp
@@ -32,9 +32,11 @@
                           convertForMessage(BMC::Transition::Reboot));
 }
 
-ipmi_ret_t ipmi_global_reset(ipmi_netfn_t netfn, ipmi_cmd_t cmd,
-                             ipmi_request_t request, ipmi_response_t response,
-                             ipmi_data_len_t data_len, ipmi_context_t context)
+/** @brief implements cold and warm reset commands
+ *  @param - None
+ *  @returns IPMI completion code.
+ */
+ipmi::RspType<> ipmiGlobalReset()
 {
     try
     {
@@ -43,24 +45,23 @@
     catch (std::exception& e)
     {
         log<level::ERR>(e.what());
-        return IPMI_CC_UNSPECIFIED_ERROR;
+        return ipmi::responseUnspecifiedError();
     }
 
     // Status code.
-    ipmi_ret_t rc = IPMI_CC_OK;
-    *data_len = 0;
-    return rc;
+    return ipmi::responseSuccess();
 }
 
 void register_netfn_global_functions()
 {
+
     // Cold Reset
-    ipmi_register_callback(NETFUN_APP, IPMI_CMD_COLD_RESET, NULL,
-                           ipmi_global_reset, PRIVILEGE_ADMIN);
-
-    // <Warm Reset>
-    ipmi_register_callback(NETFUN_APP, IPMI_CMD_WARM_RESET, NULL,
-                           ipmi_global_reset, PRIVILEGE_ADMIN);
-
+    ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnApp,
+                          ipmi::app::cmdColdReset, ipmi::Privilege::Admin,
+                          ipmiGlobalReset);
+    // Warm Reset
+    ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnApp,
+                          ipmi::app::cmdWarmReset, ipmi::Privilege::Admin,
+                          ipmiGlobalReset);
     return;
 }