Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / eae8859cae6655ccc000c792a4b51cf8ac38b0c1
commiteae8859cae6655ccc000c792a4b51cf8ac38b0c1[log] [tgz]
authorWilly Tu <wltu@google.com>Tue Dec 13 14:28:02 2022 -0800
committerWilly Tu <wltu@google.com>Tue Dec 13 14:29:18 2022 -0800
tree47f30ab1686f27815db774888b6b1968926d0be9
parent511369844523794fd2dd1655528b48fe38b8e1e5 [diff]
sensorhander: Create overrides for SensorDataEventRecordBody

set_id_strlen + set_id_type does not have function to support
SensorDataEventRecordBody, but is currently being used.

Without it the build failed like the following
```
../dbus-sdr/sensorcommands.cpp: In function 'bool ipmi::constructVrSdr(Context::ptr, const std::unordered_set<std::__cxx11::basic_string<char> >&, uint16_t, uint16_t, const std::string&, const std::string&, get_sdr::SensorDataEventRecord&)':
../dbus-sdr/sensorcommands.cpp:1916:44: error: cannot convert 'get_sdr::SensorDataEventRecordBody*' to 'get_sdr::SensorDataFullRecordBody*'
 1916 |     get_sdr::body::set_id_strlen(nameSize, &record.body);
      |                                            ^~~~~~~~~~~~
      |                                            |
      |                                            get_sdr::SensorDataEventRecordBody*
In file included from ../include/dbus-sdr/storagecommands.hpp:18,
                 from ../dbus-sdr/sensorcommands.cpp:21:
../sensorhandler.hpp:572:66: note:   initializing argument 2 of 'void get_sdr::body::set_id_strlen(uint8_t, get_sdr::SensorDataFullRecordBody*)'
  572 | inline void set_id_strlen(uint8_t len, SensorDataFullRecordBody* body)
      |                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../dbus-sdr/sensorcommands.cpp:1917:35: error: cannot convert 'get_sdr::SensorDataEventRecordBody*' to 'get_sdr::SensorDataFullRecordBody*'
 1917 |     get_sdr::body::set_id_type(3, &record.body); // "8-bit ASCII + Latin 1"
      |                                   ^~~~~~~~~~~~
      |                                   |
      |                                   get_sdr::SensorDataEventRecordBody*
../sensorhandler.hpp:581:65: note:   initializing argument 2 of 'void get_sdr::body::set_id_type(uint8_t, get_sdr::SensorDataFullRecordBody*)'
  581 | inline void set_id_type(uint8_t type, SensorDataFullRecordBody* body
```

Change-Id: Ic780a1f848a9e6bcea79fd9822539184d1d985cf
Signed-off-by: Willy Tu <wltu@google.com>
1 file changed
tree: 47f30ab1686f27815db774888b6b1968926d0be9
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. generate_whitelist_create.sh
  30. globalhandler.cpp
  31. globalhandler.hpp
  32. groupext.cpp
  33. host-cmd-manager.cpp
  34. host-cmd-manager.hpp
  35. host-interface.cpp
  36. host-interface.hpp
  37. host-ipmid-whitelist.conf
  38. ipmi_fru_info_area.cpp
  39. ipmi_fru_info_area.hpp
  40. ipmid-new.cpp
  41. ipmisensor.cpp
  42. ipmiwhitelist.hpp
  43. LICENSE
  44. meson.build
  45. meson_options.txt
  46. OWNERS
  47. read_fru_data.cpp
  48. read_fru_data.hpp
  49. README.md
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. transporthandler.hpp
  70. whitelist-filter.cpp
README.md

Compile ipmid with default options:

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults:

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report:

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage