commit f365c7ffccfaae696694865da3782cf52e62cbef
author Alexander Hansen <alexander.hansen@9elements.com> Fri Nov 14 12:08:34 2025 +0100
committer Alexander Hansen <alexander.hansen@9elements.com> Fri Nov 14 14:07:37 2025 +0100
tree 96147d22ba25b5ab170b9bab2542b85d8d40fd7f
parent 2260ff34ee49dc4e1ee82eead6c87c8e54d4bbdc

Sensor.Value: use PDI constants

Use PDI constants instead of local definitions.

Tested: Inspection only.

Change-Id: I42c4f33a7e2f98a1adbac5a92aea4df952442990
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

sensorhandler.cpp

diff --git a/sensorhandler.cpp b/sensorhandler.cpp
index cb6942f..1acdf7e 100644
--- a/sensorhandler.cpp
+++ b/sensorhandler.cpp
@@ -42,6 +42,8 @@
 using InternalFailure =
     sdbusplus::error::xyz::openbmc_project::common::InternalFailure;
 
+using SensorValue = sdbusplus::common::xyz::openbmc_project::sensor::Value;
+
 void registerNetFnSenFunctions() __attribute__((constructor));
 
 struct sensorTypemap_t
@@ -444,7 +446,7 @@
 }
 
 const std::set<std::string> analogSensorInterfaces = {
-    "xyz.openbmc_project.Sensor.Value",
+    SensorValue::interface,
     "xyz.openbmc_project.Control.FanPwm",
 };
 
@@ -829,8 +831,6 @@
               >
     ipmiSensorGetSensorThresholds(ipmi::Context::ptr& ctx, uint8_t sensorNum)
 {
-    constexpr auto valueInterface = "xyz.openbmc_project.Sensor.Value";
-
     const auto iter = ipmi::sensor::sensors.find(sensorNum);
     if (iter == ipmi::sensor::sensors.end())
     {
@@ -840,7 +840,7 @@
     const auto info = iter->second;
 
     // Proceed only if the sensor value interface is implemented.
-    if (info.propertyInterfaces.find(valueInterface) ==
+    if (info.propertyInterfaces.find(SensorValue::interface) ==
         info.propertyInterfaces.end())
     {
         // return with valid mask as 0
@@ -911,8 +911,6 @@
         return ipmi::responseSuccess();
     }
 
-    constexpr auto valueInterface = "xyz.openbmc_project.Sensor.Value";
-
     const auto iter = ipmi::sensor::sensors.find(sensorNum);
     if (iter == ipmi::sensor::sensors.end())
     {
@@ -922,7 +920,7 @@
     const auto& info = iter->second;
 
     // Proceed only if the sensor value interface is implemented.
-    if (info.propertyInterfaces.find(valueInterface) ==
+    if (info.propertyInterfaces.find(SensorValue::interface) ==
         info.propertyInterfaces.end())
     {
         // return with valid mask as 0