chassishandler: Optimize ipmi complete code
Since the custom return status code is only used in
chassishandler.cpp, optimize the ipmi status code and declare the
return status code in chassishandler.cpp.
Change-Id: I2e9d9b2c00969ba1848a3720af7afc17dc88b712
Signed-off-by: George Liu <liuxiwei@ieisystem.com>
diff --git a/chassishandler.cpp b/chassishandler.cpp
index 4e08e30..a0a91d2 100644
--- a/chassishandler.cpp
+++ b/chassishandler.cpp
@@ -61,11 +61,17 @@
namespace ipmi
{
constexpr Cc ccParmNotSupported = 0x80;
+constexpr Cc ccFailSetInProgress = 0x81;
static inline auto responseParmNotSupported()
{
return response(ccParmNotSupported);
}
+
+static inline auto responsefailSetInProgress()
+{
+ return response(ccFailSetInProgress);
+}
} // namespace ipmi
void registerNetFnChassisFunctions() __attribute__((constructor));
@@ -2051,7 +2057,7 @@
if ((transferStatus == setInProgress) &&
(static_cast<uint8_t>(setInProgressFlag) != setComplete))
{
- return ipmi::response(failSetInProgress);
+ return ipmi::responsefailSetInProgress();
}
transferStatus = static_cast<uint8_t>(setInProgressFlag);
return ipmi::responseSuccess();
diff --git a/chassishandler.hpp b/chassishandler.hpp
index 82c09bc..31e63fb 100644
--- a/chassishandler.hpp
+++ b/chassishandler.hpp
@@ -7,13 +7,6 @@
// IPMI Command for a Net Function number as specified by IPMI V2.0 spec.
using Cmd = uint8_t;
-// ipmi function return the status code
-using Cc = uint8_t;
-
-// Command specific completion codes
-constexpr Cc ccParmNotSupported = 0xCD;
-constexpr Cc failSetInProgress = 0x81;
-
// Various Chassis operations under a single command.
constexpr Cmd cmdPowerOff = 0x00;
constexpr Cmd cmdPowerOn = 0x01;