commit f7452cb646898a90f85d95208721d714c8b1709e
author George Liu <liuxiwei@ieisystem.com> Thu Dec 05 17:04:45 2024 +0800
committer George Liu <liuxiwei@ieisystem.com> Mon Mar 03 09:54:41 2025 +0800
tree 583f8bdf3b5a6a1a766a66cdec4921c5415c1e10
parent 2e32747557b742470a5d21c2da1b8761ba50b188

sensorhandler: remove IPMI_CMD command

The IPMI_CMD declared in sensorhandler.hpp is redundant because these
commands are already declared in api-types.hpp, so this commit
removes all IPMI_CMD in sensorhandler.hpp.

Change-Id: Idc3586d82f3d9905c5ae214e652724ca6425aae7
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

sensorhandler.cpp

diff --git a/sensorhandler.cpp b/sensorhandler.cpp
index a48b0f2..961b236 100644
--- a/sensorhandler.cpp
+++ b/sensorhandler.cpp
@@ -1568,16 +1568,16 @@
                           ipmi::Privilege::User, ipmiSenSetSensorThresholds);
 
     // <Get Device SDR>
-    ipmi_register_callback(NETFUN_SENSOR, IPMI_CMD_GET_DEVICE_SDR, nullptr,
-                           ipmi_sen_get_sdr, PRIVILEGE_USER);
+    ipmi_register_callback(NETFUN_SENSOR, ipmi::sensor_event::cmdGetDeviceSdr,
+                           nullptr, ipmi_sen_get_sdr, PRIVILEGE_USER);
 
 #endif
 
     // Common Handers used by both implementation.
 
     // <Platform Event Message>
-    ipmi_register_callback(NETFUN_SENSOR, IPMI_CMD_PLATFORM_EVENT, nullptr,
-                           ipmicmdPlatformEvent, PRIVILEGE_OPERATOR);
+    ipmi_register_callback(NETFUN_SENSOR, ipmi::sensor_event::cmdPlatformEvent,
+                           nullptr, ipmicmdPlatformEvent, PRIVILEGE_OPERATOR);
 
     // <Get Sensor Type>
     ipmi::registerHandler(ipmi::prioOpenBmcBase, ipmi::netFnSensor,

sensorhandler.hpp

diff --git a/sensorhandler.hpp b/sensorhandler.hpp
index 6e19666..74b1862 100644
--- a/sensorhandler.hpp
+++ b/sensorhandler.hpp
@@ -7,19 +7,6 @@
 
 #include <exception>
 
-// IPMI commands for net functions.
-enum ipmi_netfn_sen_cmds
-{
-    IPMI_CMD_PLATFORM_EVENT = 0x2,
-    IPMI_CMD_GET_DEVICE_SDR_INFO = 0x20,
-    IPMI_CMD_GET_DEVICE_SDR = 0x21,
-    IPMI_CMD_RESERVE_DEVICE_SDR_REPO = 0x22,
-    IPMI_CMD_GET_SENSOR_READING = 0x2D,
-    IPMI_CMD_GET_SENSOR_TYPE = 0x2F,
-    IPMI_CMD_SET_SENSOR = 0x30,
-    IPMI_CMD_GET_SENSOR_THRESHOLDS = 0x27,
-};
-
 /**
  * @enum device_type
  * IPMI FRU device types