commit fc37e59e2f85e585ee830e801b5b26a2c859c86b
author Vernon Mauery <vernon.mauery@linux.intel.com> Wed Dec 19 14:55:15 2018 -0800
committer Vernon Mauery <vernon.mauery@linux.intel.com> Wed Dec 19 15:40:27 2018 -0800
tree 860d6c1a630558246809c348682a889e26c52a14
parent 744b3c8b840a13ed4a6c07836ead4a0c88911437

netipmid: replace std::cerr with phosphor::logging calls

This is part of a cleanup and standardization effort of code to get
existing code up to date.

Change-Id: I0c982ef8d7afa2f56a9cd204bb8ac3112769641c
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

command_table.cpp

diff --git a/command_table.cpp b/command_table.cpp
index 26859a5..d0ef173 100644
--- a/command_table.cpp
+++ b/command_table.cpp
@@ -6,7 +6,6 @@
 #include "sessions_manager.hpp"
 
 #include <iomanip>
-#include <iostream>
 #include <phosphor-logging/elog-errors.hpp>
 #include <phosphor-logging/log.hpp>
 #include <xyz/openbmc_project/Common/error.hpp>
@@ -62,9 +61,8 @@
         // exceeded message
         if (elapsedSeconds > 2s)
         {
-            std::cerr << "E> IPMI command timed out:Elapsed time = "
-                      << elapsedSeconds.count() << "s"
-                      << "\n";
+            log<level::ERR>("IPMI command timed out",
+                            entry("DELAY=%d", elapsedSeconds.count()));
         }
     }
     return response;
@@ -81,8 +79,10 @@
     {
         errResponse.resize(1);
         errResponse[0] = IPMI_CC_INSUFFICIENT_PRIVILEGE;
-        std::cerr << "E> Table::Not enough privileges for command 0x"
-                  << std::hex << command.command << "\n";
+        log<level::INFO>("Table: Insufficient privilege for command",
+                         entry("LUN=%x", int(command.NetFnLun.lun)),
+                         entry("NETFN=%x", int(command.NetFnLun.netFn)),
+                         entry("CMD=%x", command.cmd));
         return errResponse;
     }
 
@@ -112,8 +112,11 @@
         // and return sane error code.
         catch (const std::exception& e)
         {
-            std::cerr << "E> Unspecified error for command 0x" << std::hex
-                      << command.command << " - " << e.what() << "\n";
+            log<level::ERR>("Table: Unspecified error for command",
+                            entry("EXCEPTION=%s", e.what()),
+                            entry("LUN=%x", int(command.NetFnLun.lun)),
+                            entry("NETFN=%x", int(command.NetFnLun.netFn)),
+                            entry("CMD=%x", command.cmd));
             respSize = 0;
             // fall through
         }