Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 9ab2f94794c4f4ca1856d35c87abe9fa77356fa3
commit9ab2f94794c4f4ca1856d35c87abe9fa77356fa3[log] [tgz]
authorAlex Qiu <xqiu@google.com>Wed Jul 15 17:56:21 2020 -0700
committerWilly Tu <wltu@google.com>Wed Apr 14 20:35:25 2021 +0000
tree47b902f4fcd1b1955cc8908ced27a1dcf7b33bed
parent06736b2624a264d8d7f5741098a99f048c127b36 [diff]
sensorcommands: Cache sensor data at 60s interval when requested for SDR

Temporary tuning to mitigate performance issue due to inconsistent dbus
call performance in getSensorMap().

Moving the sensor update time to after finish building the map allow the
data to be cached for the the build time plus sensorMapUpdatePeriod.

A SDR scan is observed to take about half a minute, and SDR is scanned
for 17 times during host boot, which adds minutes to host
boot time. However, sensor reading is seldom invoked during boot, and
the host does not poll for SDR after the first one.
Based on these facts, deploy a trick that turn up cache time to 60
seconds to reduce dbus traffic when SDR is requested, while the sensor
reading update interval is not affected.
No time reduction to `ipmitool sdr` command, because it polls for
both SDR and sensor reading.

Tested:
After issuing host reboot command in BMC, host boot time recorded is
reduced from 14:40 to 11:02.
The fan sensor is still observed to be updated every 2 seconds.

Ported from:
https://gerrit.openbmc-project.xyz/c/openbmc/intel-ipmi-oem/+/40328

Signed-off-by: Alex Qiu <xqiu@google.com>
Change-Id: If45f5b850854ff5888909636507d1c47840d17b6
Signed-off-by: Willy Tu <wltu@google.com>
1 file changed
tree: 47b902f4fcd1b1955cc8908ced27a1dcf7b33bed
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. libipmid-host/
  7. scripts/
  8. softoff/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. bootstrap.sh
  20. chassishandler.cpp
  21. chassishandler.hpp
  22. configure.ac
  23. dcmihandler.cpp
  24. dcmihandler.hpp
  25. elog-errors.hpp
  26. entity_map_json.cpp
  27. entity_map_json.hpp
  28. error-HostEvent.hpp
  29. fruread.hpp
  30. generate_whitelist.sh
  31. globalhandler.cpp
  32. globalhandler.hpp
  33. groupext.cpp
  34. host-cmd-manager.cpp
  35. host-cmd-manager.hpp
  36. host-interface.cpp
  37. host-interface.hpp
  38. host-ipmid-whitelist.conf
  39. ipmi_fru_info_area.cpp
  40. ipmi_fru_info_area.hpp
  41. ipmid-new.cpp
  42. ipmisensor.cpp
  43. ipmiwhitelist.hpp
  44. LICENSE
  45. MAINTAINERS
  46. Makefile.am
  47. read_fru_data.cpp
  48. read_fru_data.hpp
  49. README.md
  50. sample.cpp
  51. sample.h
  52. selutility.cpp
  53. selutility.hpp
  54. sensordatahandler.cpp
  55. sensordatahandler.hpp
  56. sensorhandler.cpp
  57. sensorhandler.hpp
  58. settings.cpp
  59. settings.hpp
  60. storageaddsel.cpp
  61. storageaddsel.hpp
  62. storagehandler.cpp
  63. storagehandler.hpp
  64. sys_info_param.cpp
  65. sys_info_param.hpp
  66. systemintfcmds.cpp
  67. systemintfcmds.hpp
  68. testaddsel.cpp
  69. testit.cpp
  70. transporthandler.cpp
  71. transporthandler.hpp
  72. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.