Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / ffa76e59f81feee67bdbf47f4df94baf72742c0d
commitffa76e59f81feee67bdbf47f4df94baf72742c0d[log] [tgz]
authorTom Joseph <rushtotom@gmail.com>Tue Jan 17 15:12:32 2023 +0530
committerTom Joseph <rushtotom@gmail.com>Tue Jan 17 15:29:26 2023 +0530
tree0d10099a8694dfe010eef6d8f360be694d9b1072
parentefe2668675e0d5f1a486e0b4147563a02796f3eb [diff]
dbus-sdr: Revert sensor name modifications partially

With commit [1] the leaf of the D-Bus object path was stripped of
well known suffixes, in addition to that `_` was replaced by space.

Replacing `_` with space is not needed to solve the problem statement
[2]. For sensor names which are less than 16 characters, this creates
expectation differences on scripts which tried to validate the ipmitool
output.

[1] https://github.com/openbmc/phosphor-host-ipmid/commit/d950f410b71e0ac4650519eb5bf7ea683e98684d
[2] https://github.com/openbmc/intel-ipmi-oem/issues/4

Change-Id: If7028e517385ebfc1fc3541a6c23d559ad0c8d69
Signed-off-by: Tom Joseph <rushtotom@gmail.com>
1 file changed
tree: 0d10099a8694dfe010eef6d8f360be694d9b1072
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. generate_whitelist_create.sh
  30. globalhandler.cpp
  31. globalhandler.hpp
  32. groupext.cpp
  33. host-cmd-manager.cpp
  34. host-cmd-manager.hpp
  35. host-interface.cpp
  36. host-interface.hpp
  37. host-ipmid-whitelist.conf
  38. ipmi_fru_info_area.cpp
  39. ipmi_fru_info_area.hpp
  40. ipmid-new.cpp
  41. ipmisensor.cpp
  42. ipmiwhitelist.hpp
  43. LICENSE
  44. meson.build
  45. meson_options.txt
  46. OWNERS
  47. read_fru_data.cpp
  48. read_fru_data.hpp
  49. README.md
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. transporthandler.hpp
  70. whitelist-filter.cpp
README.md

Compile ipmid with default options:

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults:

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report:

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage