commit a396c85ae81f8d310a43aa39ab611ae7d644eb9e
author Willy Tu <wltu@google.com> Thu Dec 09 22:23:14 2021 -0800
committer Willy Tu <wltu@google.com> Mon Feb 07 03:16:22 2022 -0800
tree b2071f4e4c14bc940cdc437eb5adaf74ad0aeeb6
parent 6a5e0a1cba979c3c793e794c41481221da9a4e33

phosphor-host-postd: Cleanup CodeChecker Errors

Removed the following error messages:
bugprone-unused-raii
  - object destroyed immediately after creation; did you mean to name
  the object
clang-diagnostic-defaulted-function-deleted
  - explicitly defaulted move assignment operator is implicitly deleted
clang-diagnostic-unused-private-field
  - private field 'bus' is not used

Change-Id: I493da3433db50396354b6b9a43c452becba91790
Signed-off-by: Willy Tu <wltu@google.com>

lpcsnoop/snoop_listen.hpp

diff --git a/lpcsnoop/snoop_listen.hpp b/lpcsnoop/snoop_listen.hpp
index 70e14b4..174e664 100644
--- a/lpcsnoop/snoop_listen.hpp
+++ b/lpcsnoop/snoop_listen.hpp
@@ -40,12 +40,12 @@
 
   public:
     SnoopListen(sdbusplus::bus::bus& busIn, sd_bus_message_handler_t handler) :
-        bus(busIn), signal(busIn, GetMatchRule().c_str(), handler, this)
+        signal(busIn, GetMatchRule().c_str(), handler, this)
     {
     }
 
     SnoopListen(sdbusplus::bus::bus& busIn, message_handler_t handler) :
-        bus(busIn), signal(busIn, GetMatchRule(), handler)
+        signal(busIn, GetMatchRule(), handler)
     {
     }
 
@@ -63,7 +63,6 @@
     SnoopListen& operator=(SnoopListen&&) = default;
 
   private:
-    sdbusplus::bus::bus& bus;
     sdbusplus::bus::match_t signal;
 
     /*

main.cpp

diff --git a/main.cpp b/main.cpp
index 3a3b4ce..1ccfd21 100644
--- a/main.cpp
+++ b/main.cpp
@@ -165,7 +165,7 @@
     auto bus = sdbusplus::bus::new_default();
 
     // Add systemd object manager.
-    sdbusplus::server::manager::manager(bus, snoopObject);
+    sdbusplus::server::manager::manager snoopdManager(bus, snoopObject);
 
     PostReporter reporter(bus, snoopObject, deferSignals);
     reporter.emit_object_added();