Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-hwmon / 341e3cfa73af2dc87a1279e1189d03a61b8b8507
commit341e3cfa73af2dc87a1279e1189d03a61b8b8507[log] [tgz]
authorMatt Spinler <spinler@us.ibm.com>Wed Jul 09 13:37:41 2025 -0500
committerMatt Spinler <spinler@us.ibm.com>Fri Jul 11 14:59:23 2025 +0000
treed44d6f4c11d2cf9e75498b9dc3e10615008c7389
parent35f96bcb178a7ac43f23afbc973eeea2d80b397a [diff]
Give negative-errno-on-fail a default

The 'negative-errno-on-fail' option was initially added when the
repo used autotools, and if not specified it defaulted to false.

When the repo was moved to meson a default value wasn't given, and
either at that point, or possibly when a new version of meson came
along, the option would get set to true if no explicit value was given.

Go back to the original behavior by specifying a default value of false
in meson.options.

Tested:
Before fix:

$ grep NEGATIVE build/config.h
  #define NEGATIVE_ERRNO_ON_FAIL 1

After:

$ grep NEGATIVE build/config.h
  #define NEGATIVE_ERRNO_ON_FAIL 0

Change-Id: Ib866edc4c774f72c3fdda596cb023280e8fe60f0
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
1 file changed
tree: d44d6f4c11d2cf9e75498b9dc3e10615008c7389
  1. msl/
  2. subprojects/
  3. test/
  4. tools/
  5. .clang-format
  6. .gitignore
  7. .lcovrc
  8. .shellcheck
  9. 70-hwmon.rules
  10. 70-iio.rules
  11. average.cpp
  12. average.hpp
  13. env.cpp
  14. env.hpp
  15. fan_pwm.cpp
  16. fan_pwm.hpp
  17. fan_speed.cpp
  18. fan_speed.hpp
  19. gpio_handle.cpp
  20. gpio_handle.hpp
  21. hwmon.cpp
  22. hwmon.hpp
  23. hwmonio.cpp
  24. hwmonio.hpp
  25. interface.hpp
  26. LICENSE
  27. mainloop.cpp
  28. mainloop.hpp
  29. meson.build
  30. meson.options
  31. OWNERS
  32. phosphor-hwmon.conf
  33. readd.cpp
  34. README.iio.md
  35. README.md
  36. sensor.cpp
  37. sensor.hpp
  38. sensorset.cpp
  39. sensorset.hpp
  40. start_hwmon.sh.in
  41. sysfs.cpp
  42. sysfs.hpp
  43. targets.hpp
  44. thresholds.hpp
  45. types.hpp
  46. util.hpp
  47. xyz.openbmc_project.Hwmon@.service
README.md

phosphor-hwmon

Exposes generic hwmon entries as DBus objects. More information can be found at Sensor Architecture

To Build

To build this package, do the following steps:

  1. meson setup build
  2. ninja -C build

To clean the repository run rm -rf build.

D-Bus bus names

To enable the use of Linux features like cgroups prioritization and udev/systemd control, one instance of phosphor-hwmon is intended to be run per hwmon sysfs class instance.

This requires an algorithm for selecting a stable, well-known D-Bus busname.

The algorithm is <PREFIX>-<ID>.Hwmon<N> where PREFIX is a meson configurable prefix (BUSNAME_PREFIX=xyz.openbmc_project by default), ID is either a std::hash of the /sys/devices path backing the hwmon class instance or provided suffix value from the command line, and N is the implemented phosphor-hwmon D-Bus API version.