commit 5ec68abbcbac6e3475cff13cf151e6569fc07337
author Brad Bishop <bradleyb@fuzziesquirrel.com> Mon Mar 27 13:41:02 2017 -0400
committer Brad Bishop <bradleyb@fuzziesquirrel.com> Mon Mar 27 13:57:44 2017 -0400
tree c7eb3b1041383888174bba50589b574486d71c51
parent 973886db122187b4d30ad0d359c1e9db0e23a706

Use std::filesystem when generating callout paths

Change-Id: Ia4dbe7e27368a7136d3767f105f6af78d9627c3f
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

sysfs.cpp

diff --git a/sysfs.cpp b/sysfs.cpp
index b985149..75a1376 100644
--- a/sysfs.cpp
+++ b/sysfs.cpp
@@ -51,11 +51,14 @@
                          const std::string& id,
                          const std::string& sensor)
 {
+    namespace fs = std::experimental::filesystem;
+
     int value = 0;
-    std::string instancePath = root + '/' + instance;
+    std::ifstream ifs;
+    fs::path instancePath{root};
+    instancePath /= instance;
     std::string fullPath = make_sysfs_path(instancePath,
                                            type, id, sensor);
-    std::ifstream ifs;
 
     ifs.exceptions(std::ifstream::failbit
                    | std::ifstream::badbit
@@ -69,17 +72,16 @@
     {
         // Too many GCC bugs (53984, 66145) to do
         // this the right way...
-        using Cleanup = phosphor::utility::Free<char>;
 
         // errno should still reflect the error from the failing open
         // or read system calls that got us here.
         auto rc = errno;
-        std::string devicePath = instancePath + "/device";
-        auto real = std::unique_ptr<char, Cleanup>(
-                        realpath(devicePath.c_str(), nullptr));
+        instancePath /= "device";
         phosphor::logging::log<phosphor::logging::level::ERR>(
             strerror(rc),
-            phosphor::logging::entry("CALLOUT_DEVICE_PATH=%s", real.get()),
+            phosphor::logging::entry(
+                "CALLOUT_DEVICE_PATH=%s",
+                fs::canonical(instancePath).c_str()),
             phosphor::logging::entry("CALLOUT_ERRNO=%d", rc));
         exit(EXIT_FAILURE);
     }