tree 21b8771bef387deae6b8c00e3ec39935da86ef09
parent 94a04c4e9162800af7b2823cd52292e3aa189dc3
author Kun Yi <kunyi731@gmail.com> 1566407127 -0700
committer Kun Yi <kunyi731@gmail.com> 1568235517 -0700

Rework envMock

Instead of mocking all the functions, only mock std::getenv.
Now each test only needs to provide an EnvImpl that delegate calls to
mockEnv in order to inject dependencies on std::getenv. This for several
reasons:
1. Any call to env::getEnv() will be calling the real implementation of
the C++ code, and testing real code is better than testing mocks.
2. It is easier to write a fake class that takes a config string which
can greatly simplify test cases.
3. We can now write unit tests that ensure the number of times
std::getenv gets called (should be once, but multiple times right now).

Tested: unit tests still pass

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I3e5aff7fa5d025de1b8ae798af43b97d31151ab9