utils: improve exception string with variant types
The variant visitor raises an exception if the variant cannot be
properly converted, but previously gave no indication as to what the
failing type conversion was. Add the use of `__PRETTY_FUNCTION` to the
exception string so that the types are recorded in the exception.
This results in an exception like:
Invalid conversion in MakeVariantVisitor::static auto
phosphor::inventory::manager::MakeVariantVisitor<V>::Make<T, Arg,
Enable>::make(Arg&&) [with T = std::variant<sdbusplus::xyz::openbmc_project::Inventory::Item::server::Chassis::ChassisType>;
Arg = const std::__cxx11::basic_string<char>&; Enable = void;
V = std::variant<sdbusplus::xyz::openbmc_project::Inventory::Item::server::Chassis::ChassisType>]
Instead of the previous exception which simply stated:
Invalid conversion in MakeVariantVisitor
It would probably be better to use C++20's std::source_location but the
autotools structure currently in place does not allow simple usage of
C++20.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I59e0ce0d6899a88e1e711a7921c0d12290fa4995
diff --git a/utils.hpp b/utils.hpp
index eacc70e..24ced13 100644
--- a/utils.hpp
+++ b/utils.hpp
@@ -35,7 +35,8 @@
static auto make(Arg&& arg)
{
throw std::runtime_error(
- "Invalid conversion in MakeVariantVisitor");
+ std::string("Invalid conversion in MakeVariantVisitor::") +
+ __PRETTY_FUNCTION__);
return T();
}
};