tree 6e62c142ecb6a5c8c44fb371aceb9202b09db9e2
parent ec2709fe1bb632b477446343672421f13e8b8362
author Patrick Williams <patrick@stwcx.xyz> 1626192739 -0500
committer Patrick Williams <patrick@stwcx.xyz> 1626192741 -0500

utils: improve exception string with variant types

The variant visitor raises an exception if the variant cannot be
properly converted, but previously gave no indication as to what the
failing type conversion was.  Add the use of `__PRETTY_FUNCTION` to the
exception string so that the types are recorded in the exception.

This results in an exception like:

    Invalid conversion in MakeVariantVisitor::static auto
    phosphor::inventory::manager::MakeVariantVisitor<V>::Make<T, Arg,
    Enable>::make(Arg&&) [with T = std::variant<sdbusplus::xyz::openbmc_project::Inventory::Item::server::Chassis::ChassisType>;
    Arg = const std::__cxx11::basic_string<char>&; Enable = void;
    V = std::variant<sdbusplus::xyz::openbmc_project::Inventory::Item::server::Chassis::ChassisType>]

Instead of the previous exception which simply stated:

    Invalid conversion in MakeVariantVisitor

It would probably be better to use C++20's std::source_location but the
autotools structure currently in place does not allow simple usage of
C++20.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I59e0ce0d6899a88e1e711a7921c0d12290fa4995