manager: explicitly pass deferSignal
Explicitly pass the deferSignal parameter to the dbus bindings to enable
creating objects without emitting signals.
The patch does not introduce any functional change - only future
capability; the dbus binding argument is defaulted to emit a signal
(deferSignal = false) and that logic is preserved - moved from the
binding call site to higher up the call stack (updateInterfaces).
A careful observer may notice this patch highlights that interfaces are
constructed with the map-of-properties constructor with signals enabled.
This is arguably a bug in the bindings - it would never make sense to
construct an interface in this fashion and send PropertiesChanged
signals while the interface is in the process of being constructed.
This patch retains the current broken behavior, with a fix to be
provided in a later patch.
Change-Id: I0d9ef93651595b751e96cae07d9f1095770c05a6
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
diff --git a/manager.cpp b/manager.cpp
index 20cdb05..0aa2176 100644
--- a/manager.cpp
+++ b/manager.cpp
@@ -166,16 +166,16 @@
// Add the new interface.
auto& ctor = std::get<MakeInterfaceType>(opsit->second);
refaceit = refaces.insert(
- refaceit,
- std::make_pair(ifaceit->first, ctor(_bus, path.str.c_str(),
- ifaceit->second)));
+ refaceit, std::make_pair(ifaceit->first,
+ ctor(_bus, path.str.c_str(),
+ ifaceit->second, false)));
signals.push_back(ifaceit->first);
}
else
{
// Set the new property values.
auto& assign = std::get<AssignInterfaceType>(opsit->second);
- assign(ifaceit->second, refaceit->second);
+ assign(ifaceit->second, refaceit->second, false);
}
if (!restoreFromCache)
{