Revert "Add ipmi response buffer size check for all commands"
This reverts commit 88ca532a74375cc99bd979fbb037d07e5ee76cce.
Reason for revert: ipmi::getChannelMaxTransferSize is only using the
default channel and may fail when using a different channel.
Change-Id: Ic080de6f51c05f86807b81dfd3dd38a87fc2dbf5
Signed-off-by: Willy Tu <wltu@google.com>
diff --git a/process.cpp b/process.cpp
index cdf73fa..2481fa2 100644
--- a/process.cpp
+++ b/process.cpp
@@ -110,7 +110,7 @@
ipmi_ret_t processBlobCommand(IpmiBlobHandler cmd, ManagerInterface* mgr,
const uint8_t* reqBuf, uint8_t* replyCmdBuf,
- size_t* dataLen, size_t maxSize)
+ size_t* dataLen)
{
ipmi_ret_t result = cmd(mgr, reqBuf, replyCmdBuf, dataLen);
if (result != IPMI_CC_OK)
@@ -134,12 +134,6 @@
return IPMI_CC_UNSPECIFIED_ERROR;
}
- /* Make sure the reply size fits the ipmi buffer */
- if (replyLength > maxSize)
- {
- return IPMI_CC_RESPONSE_ERROR;
- }
-
/* The command, whatever it was, replied, so let's set the CRC. */
std::vector<std::uint8_t> crcBuffer(replyCmdBuf + sizeof(uint16_t),
replyCmdBuf + replyLength);
@@ -150,7 +144,7 @@
return result;
}
-ipmi_ret_t handleBlobCommand(size_t maxSize, ipmi_cmd_t, const uint8_t* reqBuf,
+ipmi_ret_t handleBlobCommand(ipmi_cmd_t, const uint8_t* reqBuf,
uint8_t* replyCmdBuf, size_t* dataLen)
{
/* It's holding at least a sub-command. The OEN is trimmed from the bytes
@@ -172,7 +166,7 @@
}
return processBlobCommand(command, getBlobManager(), reqBuf, replyCmdBuf,
- dataLen, maxSize);
+ dataLen);
}
} // namespace blobs