commit 035bbbb9865cf656ddb4e32e58c228b638d5d858
author Patrick Venture <venture@google.com> Wed Dec 12 14:59:52 2018 -0800
committer Patrick Venture <venture@google.com> Thu Dec 13 09:24:58 2018 -0800
tree 7f63930707bd8150fe05d5d73c6b2704ed99c7b7
parent 9b750aa1ab014375954464b5fb92b7461e60eeef

tools: return data or throw exception on ipmi resp

When the IPMI_CC is non-zero, throw an exception and include the code,
otherwise if the response buffer is non-null, return the bytes received.

Change-Id: Id81281d7fd79f3075fcdd4bbf86ffdd83d8a3721
Signed-off-by: Patrick Venture <venture@google.com>

tools/ipmi_errors.hpp

diff --git a/tools/ipmi_errors.hpp b/tools/ipmi_errors.hpp
new file mode 100644
index 0000000..fd1f032
--- /dev/null
+++ b/tools/ipmi_errors.hpp
@@ -0,0 +1,24 @@
+#pragma once
+
+#include <exception>
+#include <sstream>
+#include <string>
+
+class IpmiException : public std::exception
+{
+  public:
+    explicit IpmiException(int cc)
+    {
+        std::ostringstream smessage;
+        smessage << "Received IPMI_CC: " << cc;
+        message = smessage.str();
+    }
+
+    virtual const char* what() const noexcept override
+    {
+        return message.c_str();
+    }
+
+  private:
+    std::string message;
+};

tools/ipmi_handler.cpp

diff --git a/tools/ipmi_handler.cpp b/tools/ipmi_handler.cpp
index 7a6e407..76bd3e0 100644
--- a/tools/ipmi_handler.cpp
+++ b/tools/ipmi_handler.cpp
@@ -16,7 +16,8 @@
 
 #include "ipmi_handler.hpp"
 
-int IpmiHandler::sendPacket(const std::vector<std::uint8_t>& data)
+std::vector<std::uint8_t>
+    IpmiHandler::sendPacket(const std::vector<std::uint8_t>& data)
 {
-    return 0;
+    return {};
 }

tools/ipmi_handler.hpp

diff --git a/tools/ipmi_handler.hpp b/tools/ipmi_handler.hpp
index ea42507..9e86f42 100644
--- a/tools/ipmi_handler.hpp
+++ b/tools/ipmi_handler.hpp
@@ -7,5 +7,6 @@
   public:
     IpmiHandler() = default;
 
-    int sendPacket(const std::vector<std::uint8_t>& data) override;
+    std::vector<std::uint8_t>
+        sendPacket(const std::vector<std::uint8_t>& data) override;
 };

tools/ipmi_interface.hpp

diff --git a/tools/ipmi_interface.hpp b/tools/ipmi_interface.hpp
index 932d2e8..082af9c 100644
--- a/tools/ipmi_interface.hpp
+++ b/tools/ipmi_interface.hpp
@@ -12,7 +12,9 @@
      * Send an IPMI packet to the BMC.
      *
      * @param[in] data - a vector of the IPMI packet contents.
-     * @return non-zero on failure.
+     * @return the bytes returned.
+     * @throws IpmiException on failure.
      */
-    virtual int sendPacket(const std::vector<std::uint8_t>& data) = 0;
+    virtual std::vector<std::uint8_t>
+        sendPacket(const std::vector<std::uint8_t>& data) = 0;
 };