commit 1cb87d25f79cfb905611b81348fbccb362f5e29a
author Patrick Venture <venture@google.com> Fri Aug 03 18:22:09 2018 -0700
committer Patrick Venture <venture@google.com> Tue Aug 07 10:11:40 2018 -0700
tree 5258677410ca2209f2357ac429a16eeb317a8b52
parent 9a5a79a0797294ba9f5c7b2ab79e4dcbacac0c44

ipmi: start implementing flashDataVerify

Change-Id: I446ca8573db31eb53dc7aefbe25cdb9d23d51d29
Signed-off-by: Patrick Venture <venture@google.com>

test/Makefile.am

diff --git a/test/Makefile.am b/test/Makefile.am
index 4230ce0..4d4c806 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -16,6 +16,7 @@
 	ipmi_starthash_unittest \
 	ipmi_hashdata_unittest \
 	ipmi_hashfinish_unittest \
+	ipmi_startverify_unittest \
 	ipmi_validate_unittest \
 	ipmi_command_unittest
 
@@ -39,6 +40,9 @@
 ipmi_hashfinish_unittest_SOURCES = ipmi_hashfinish_unittest.cpp
 ipmi_hashfinish_unittest_LDADD = $(top_builddir)/ipmi.o
 
+ipmi_startverify_unittest_SOURCES = ipmi_startverify_unittest.cpp
+ipmi_startverify_unittest_LDADD = $(top_builddir)/ipmi.o
+
 ipmi_validate_unittest_SOURCES = ipmi_validate_unittest.cpp
 ipmi_validate_unittest_LDADD = $(top_builddir)/ipmi.o
 

test/ipmi_startverify_unittest.cpp

diff --git a/test/ipmi_startverify_unittest.cpp b/test/ipmi_startverify_unittest.cpp
new file mode 100644
index 0000000..87e818d
--- /dev/null
+++ b/test/ipmi_startverify_unittest.cpp
@@ -0,0 +1,32 @@
+#include "ipmi.hpp"
+
+#include "updater_mock.hpp"
+
+#include <gtest/gtest.h>
+
+using ::testing::Return;
+using ::testing::StrictMock;
+
+// ipmid.hpp isn't installed where we can grab it and this value is per BMC
+// SoC.
+#define MAX_IPMI_BUFFER 64
+
+TEST(IpmiStartDataVerifyTest, CallPassedOn)
+{
+    // The IPMI handler in this case just passes on the call and returns the
+    // result without any extra validation.
+
+    StrictMock<UpdaterMock> updater;
+
+    size_t dataLen;
+    uint8_t request[MAX_IPMI_BUFFER] = {0};
+    uint8_t reply[MAX_IPMI_BUFFER] = {0};
+
+    dataLen = 1; // request is only the command.
+    request[0] = FlashSubCmds::flashDataVerify;
+
+    EXPECT_CALL(updater, startDataVerification()).WillOnce(Return(true));
+    EXPECT_EQ(IPMI_CC_OK, dataVerify(&updater, request, reply, &dataLen));
+    EXPECT_EQ(sizeof(uint8_t), dataLen);
+    EXPECT_EQ(0, reply[0]);
+}

test/updater_mock.hpp

diff --git a/test/updater_mock.hpp b/test/updater_mock.hpp
index fa912ea..2074eeb 100644
--- a/test/updater_mock.hpp
+++ b/test/updater_mock.hpp
@@ -16,4 +16,5 @@
     MOCK_METHOD1(startHash, bool(uint32_t));
     MOCK_METHOD2(hashData, bool(uint32_t, const std::vector<uint8_t>&));
     MOCK_METHOD0(hashFinish, bool());
+    MOCK_METHOD0(startDataVerification, bool());
 };