commit 2c1205db94647c196c154bae0e106933b9ff526e
author Patrick Venture <venture@google.com> Fri Aug 03 10:23:14 2018 -0700
committer Patrick Venture <venture@google.com> Mon Aug 06 12:27:39 2018 -0700
tree f06d1127f75ea941e088266cde9cf337270eb67f
parent a53a7b35085ddd41ef3cc47b084d29a1f413e818

ipmi: start implementing flashDataFinish

Change-Id: I627f6b788311650637221413a93ce7f1a3f0d0cd
Signed-off-by: Patrick Venture <venture@google.com>

test/Makefile.am

diff --git a/test/Makefile.am b/test/Makefile.am
index 9df14db..8f86df7 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -12,6 +12,7 @@
 check_PROGRAMS = \
 	ipmi_starttransfer_unittest \
 	ipmi_flashdata_unittest \
+	ipmi_flashfinish_unittest \
 	ipmi_validate_unittest
 
 TESTS = $(check_PROGRAMS)
@@ -22,5 +23,8 @@
 ipmi_flashdata_unittest_SOURCES = ipmi_flashdata_unittest.cpp
 ipmi_flashdata_unittest_LDADD = $(top_builddir)/ipmi.o
 
+ipmi_flashfinish_unittest_SOURCES = ipmi_flashfinish_unittest.cpp
+ipmi_flashfinish_unittest_LDADD = $(top_builddir)/ipmi.o
+
 ipmi_validate_unittest_SOURCES = ipmi_validate_unittest.cpp
 ipmi_validate_unittest_LDADD = $(top_builddir)/ipmi.o

test/ipmi_flashfinish_unittest.cpp

diff --git a/test/ipmi_flashfinish_unittest.cpp b/test/ipmi_flashfinish_unittest.cpp
new file mode 100644
index 0000000..6844776
--- /dev/null
+++ b/test/ipmi_flashfinish_unittest.cpp
@@ -0,0 +1,34 @@
+#include "flash-ipmi.hpp"
+#include "ipmi.hpp"
+
+#include "updater_mock.hpp"
+
+#include <cstring>
+#include <gtest/gtest.h>
+
+using ::testing::Return;
+using ::testing::StrictMock;
+
+// ipmid.hpp isn't installed where we can grab it and this value is per BMC
+// SoC.
+#define MAX_IPMI_BUFFER 64
+
+TEST(IpmiFlashFinish, CallPassedOn)
+{
+    // The data finish command does no validation as the input is empty, and
+    // simply relies on the flash manager to do work.
+
+    StrictMock<UpdaterMock> updater;
+
+    size_t dataLen;
+    uint8_t request[MAX_IPMI_BUFFER] = {0};
+    uint8_t reply[MAX_IPMI_BUFFER] = {0};
+
+    dataLen = 1; // request is only the command.
+    request[0] = FlashSubCmds::flashDataFinish;
+
+    EXPECT_CALL(updater, flashFinish()).WillOnce(Return(true));
+    EXPECT_EQ(IPMI_CC_OK, dataFinish(&updater, request, reply, &dataLen));
+    EXPECT_EQ(sizeof(uint8_t), dataLen);
+    EXPECT_EQ(0, reply[0]);
+}

test/updater_mock.hpp

diff --git a/test/updater_mock.hpp b/test/updater_mock.hpp
index ef0094b..732df31 100644
--- a/test/updater_mock.hpp
+++ b/test/updater_mock.hpp
@@ -12,4 +12,5 @@
 
     MOCK_METHOD1(start, bool(uint32_t));
     MOCK_METHOD2(flashData, bool(uint32_t, const std::vector<uint8_t>&));
+    MOCK_METHOD0(flashFinish, bool());
 };