bmc: enable configuration of all verification
Enable verification configuration beyond the result file check. This
patchset allows a developer to provide their own verification mechanisms
by implementing an interface and adding configuration to enable using
their custom version.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Iba5d4be75bb49d9c4ab84be8578f0306c15b5be9
diff --git a/test/firmware_createhandler_unittest.cpp b/test/firmware_createhandler_unittest.cpp
index 3bee96e..4821ffa 100644
--- a/test/firmware_createhandler_unittest.cpp
+++ b/test/firmware_createhandler_unittest.cpp
@@ -2,14 +2,10 @@
#include "firmware_handler.hpp"
#include "image_mock.hpp"
#include "util.hpp"
-
-#include <phosphor-logging/test/sdjournal_mock.hpp>
-#include <sdbusplus/test/sdbus_mock.hpp>
+#include "verification_mock.hpp"
#include <gtest/gtest.h>
-using namespace phosphor::logging;
-
namespace blobs
{
using ::testing::Return;
@@ -34,16 +30,8 @@
{FirmwareBlobHandler::UpdateFlags::lpc, &dataMock},
};
- sdbusplus::SdBusMock sdbus_mock;
- auto bus_mock = sdbusplus::get_mocked_new(&sdbus_mock);
-
- // TODO: Once we can test across log<> paths again, re-enable this test
- // as a failure test instead of a success one. EXPECT_CALL(journalMock,
- // journal_send_call(StrEq("PRIORITY=%d")))
- // .WillOnce(Return(0));
-
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
- std::move(bus_mock), blobs, data, "");
+ blobs, data, CreateVerifyMock());
// EXPECT_EQ(handler, nullptr);
EXPECT_FALSE(handler == nullptr);