commit 5c251ca550f56722280dcf17b8c48832ace07142
author Patrick Venture <venture@google.com> Fri Aug 03 18:31:01 2018 -0700
committer Patrick Venture <venture@google.com> Tue Aug 07 10:11:53 2018 -0700
tree 3250b724fceed43a62fa6c56e1e16c1e9249ad66
parent 1cb87d25f79cfb905611b81348fbccb362f5e29a

ipmi: start implementing flashAbort

Change-Id: I1a05ba7e9323046a09b8582351be987cdaab5a15
Signed-off-by: Patrick Venture <venture@google.com>

test/Makefile.am

diff --git a/test/Makefile.am b/test/Makefile.am
index 4d4c806..c02ebb0 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -17,6 +17,7 @@
 	ipmi_hashdata_unittest \
 	ipmi_hashfinish_unittest \
 	ipmi_startverify_unittest \
+	ipmi_abort_unittest \
 	ipmi_validate_unittest \
 	ipmi_command_unittest
 
@@ -43,6 +44,9 @@
 ipmi_startverify_unittest_SOURCES = ipmi_startverify_unittest.cpp
 ipmi_startverify_unittest_LDADD = $(top_builddir)/ipmi.o
 
+ipmi_abort_unittest_SOURCES = ipmi_abort_unittest.cpp
+ipmi_abort_unittest_LDADD = $(top_builddir)/ipmi.o
+
 ipmi_validate_unittest_SOURCES = ipmi_validate_unittest.cpp
 ipmi_validate_unittest_LDADD = $(top_builddir)/ipmi.o
 

test/ipmi_abort_unittest.cpp

diff --git a/test/ipmi_abort_unittest.cpp b/test/ipmi_abort_unittest.cpp
new file mode 100644
index 0000000..671a30c
--- /dev/null
+++ b/test/ipmi_abort_unittest.cpp
@@ -0,0 +1,32 @@
+#include "flash-ipmi.hpp"
+#include "ipmi.hpp"
+
+#include "updater_mock.hpp"
+
+#include <gtest/gtest.h>
+
+using ::testing::Return;
+using ::testing::StrictMock;
+
+// ipmid.hpp isn't installed where we can grab it and this value is per BMC
+// SoC.
+#define MAX_IPMI_BUFFER 64
+
+TEST(IpmiAbortTest, CallPassedOn)
+{
+    // The abort call is another pass-through command.
+
+    StrictMock<UpdaterMock> updater;
+
+    size_t dataLen;
+    uint8_t request[MAX_IPMI_BUFFER] = {0};
+    uint8_t reply[MAX_IPMI_BUFFER] = {0};
+
+    dataLen = 1; // request is only the command.
+    request[0] = FlashSubCmds::flashAbort;
+
+    EXPECT_CALL(updater, abortUpdate()).WillOnce(Return(true));
+    EXPECT_EQ(IPMI_CC_OK, abortUpdate(&updater, request, reply, &dataLen));
+    EXPECT_EQ(sizeof(uint8_t), dataLen);
+    EXPECT_EQ(0, reply[0]);
+}

test/updater_mock.hpp

diff --git a/test/updater_mock.hpp b/test/updater_mock.hpp
index 2074eeb..589df39 100644
--- a/test/updater_mock.hpp
+++ b/test/updater_mock.hpp
@@ -17,4 +17,5 @@
     MOCK_METHOD2(hashData, bool(uint32_t, const std::vector<uint8_t>&));
     MOCK_METHOD0(hashFinish, bool());
     MOCK_METHOD0(startDataVerification, bool());
+    MOCK_METHOD0(abortUpdate, bool());
 };