firmware_handler: add missing TODOs
Add some missing TODOs to various aspects of the process. In some
methods, a TODO was simply missing and in others the tag was missing
from a comment describing a required change.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I4eb8a99d8f1259ebb1fcd2aecbe62acc1b3afeba
diff --git a/firmware_handler.cpp b/firmware_handler.cpp
index af61730..af3788c 100644
--- a/firmware_handler.cpp
+++ b/firmware_handler.cpp
@@ -168,17 +168,17 @@
/* We know we support this path because canHandle is called ahead */
if (path == verifyBlobID)
{
- /* We need to return information for the verify state -- did they call
- * commit() did things start?
+ /* TODO: We need to return information for the verify state -- did they
+ * call commit() did things start?
*/
}
else if (path == activeImageBlobID)
{
- /* We need to return information for the image that's staged. */
+ /* TODO: We need to return information for the image that's staged. */
}
else if (path == activeHashBlobID)
{
- /* We need to return information for the hash that's staged. */
+ /* TODO: We need to return information for the hash that's staged. */
}
else
{
@@ -216,6 +216,12 @@
* flags used to open this session.
*/
meta->blobState = item->second->flags;
+
+ /* TODO: Implement this for the verification blob, which is what we expect.
+ * Calling stat() on the verify blob without an active session should not
+ * provide insight.
+ */
+
/* The size here refers to the size of the file -- of something analagous.
*/
meta->size = item->second->imageHandler->getSize();
@@ -450,6 +456,10 @@
return false;
}
+ /* TODO: Prevent writing to the verification blob before they trigger
+ * verification.
+ */
+
std::vector<std::uint8_t> bytes;
if (item->second->flags & UpdateFlags::ipmi)
@@ -496,6 +506,8 @@
return false;
}
+ /* TODO: Prevent writing meta to the verification blob. */
+
return item->second->dataHandler->writeMeta(data);
}