util: create util object for bmc and tool
Create a common util object for the BMC library and host tool. Place in
blobs namespace favoring BMC.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I036fd65d924c65fcfa71aba5cd76275a2941ff14
diff --git a/test/firmware_canhandle_unittest.cpp b/test/firmware_canhandle_unittest.cpp
index 21dc6a0..1ec83bd 100644
--- a/test/firmware_canhandle_unittest.cpp
+++ b/test/firmware_canhandle_unittest.cpp
@@ -1,6 +1,7 @@
#include "data_mock.hpp"
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <sdbusplus/test/sdbus_mock.hpp>
#include <vector>
@@ -23,7 +24,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
{"bcdf", &imageMock},
};
diff --git a/test/firmware_close_unittest.cpp b/test/firmware_close_unittest.cpp
index c5b8902..5bede33 100644
--- a/test/firmware_close_unittest.cpp
+++ b/test/firmware_close_unittest.cpp
@@ -1,6 +1,7 @@
#include "data_mock.hpp"
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <sdbusplus/test/sdbus_mock.hpp>
#include <vector>
@@ -23,7 +24,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -38,18 +39,17 @@
std::move(bus_mock), blobs, data);
EXPECT_CALL(dataMock, open()).WillOnce(Return(true));
- EXPECT_CALL(imageMock, open(Eq(FirmwareBlobHandler::hashBlobID)))
- .WillOnce(Return(true));
+ EXPECT_CALL(imageMock, open(StrEq(hashBlobId))).WillOnce(Return(true));
EXPECT_TRUE(handler->open(
0, OpenFlags::write | FirmwareBlobHandler::UpdateFlags::lpc,
- FirmwareBlobHandler::hashBlobID));
+ hashBlobId));
/* The active hash blob_id was added. */
auto currentBlobs = handler->getBlobIds();
EXPECT_EQ(4, currentBlobs.size());
EXPECT_EQ(1, std::count(currentBlobs.begin(), currentBlobs.end(),
- FirmwareBlobHandler::activeHashBlobID));
+ activeHashBlobId));
/* Set up close() expectations. */
EXPECT_CALL(dataMock, close());
@@ -70,7 +70,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -84,18 +84,17 @@
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
std::move(bus_mock), blobs, data);
- EXPECT_CALL(imageMock, open(Eq(FirmwareBlobHandler::hashBlobID)))
- .WillOnce(Return(true));
+ EXPECT_CALL(imageMock, open(StrEq(hashBlobId))).WillOnce(Return(true));
EXPECT_TRUE(handler->open(
0, OpenFlags::write | FirmwareBlobHandler::UpdateFlags::ipmi,
- FirmwareBlobHandler::hashBlobID));
+ hashBlobId));
/* The active hash blob_id was added. */
auto currentBlobs = handler->getBlobIds();
EXPECT_EQ(4, currentBlobs.size());
EXPECT_EQ(1, std::count(currentBlobs.begin(), currentBlobs.end(),
- FirmwareBlobHandler::activeHashBlobID));
+ activeHashBlobId));
/* Set up close() expectations. */
EXPECT_CALL(imageMock, close());
diff --git a/test/firmware_commit_unittest.cpp b/test/firmware_commit_unittest.cpp
index 425e7b9..2137383 100644
--- a/test/firmware_commit_unittest.cpp
+++ b/test/firmware_commit_unittest.cpp
@@ -1,6 +1,7 @@
#include "data_mock.hpp"
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <sdbusplus/test/sdbus_mock.hpp>
#include <vector>
@@ -23,7 +24,7 @@
*/
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
@@ -52,7 +53,7 @@
*/
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
@@ -66,12 +67,11 @@
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
std::move(bus_mock), blobs, data);
- EXPECT_CALL(imageMock1, open(FirmwareBlobHandler::hashBlobID))
- .WillOnce(Return(true));
+ EXPECT_CALL(imageMock1, open(StrEq(hashBlobId))).WillOnce(Return(true));
EXPECT_TRUE(handler->open(
0, OpenFlags::write | FirmwareBlobHandler::UpdateFlags::ipmi,
- FirmwareBlobHandler::hashBlobID));
+ hashBlobId));
EXPECT_FALSE(handler->commit(0, {}));
}
@@ -83,7 +83,7 @@
*/
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
@@ -97,8 +97,7 @@
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
std::move(bus_mock), blobs, data);
- EXPECT_TRUE(
- handler->open(0, OpenFlags::write, FirmwareBlobHandler::verifyBlobID));
+ EXPECT_TRUE(handler->open(0, OpenFlags::write, verifyBlobId));
EXPECT_TRUE(handler->commit(0, {}));
}
@@ -110,7 +109,7 @@
*/
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
@@ -124,8 +123,7 @@
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
std::move(bus_mock), blobs, data);
- EXPECT_TRUE(
- handler->open(0, OpenFlags::write, FirmwareBlobHandler::verifyBlobID));
+ EXPECT_TRUE(handler->open(0, OpenFlags::write, verifyBlobId));
/* Note: I used StrictMock<> here to just catch all the calls. However, the
* unit-tests pass if we don't use StrictMock and ignore the calls.
diff --git a/test/firmware_createhandler_unittest.cpp b/test/firmware_createhandler_unittest.cpp
index 84769cb..65aa6ef 100644
--- a/test/firmware_createhandler_unittest.cpp
+++ b/test/firmware_createhandler_unittest.cpp
@@ -1,6 +1,7 @@
#include "data_mock.hpp"
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <phosphor-logging/test/sdjournal_mock.hpp>
#include <sdbusplus/test/sdbus_mock.hpp>
@@ -25,7 +26,7 @@
// SwapJouralHandler(&journalMock);
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
};
std::vector<DataHandlerPack> data = {
diff --git a/test/firmware_delete_unittest.cpp b/test/firmware_delete_unittest.cpp
index 10c4227..49809f8 100644
--- a/test/firmware_delete_unittest.cpp
+++ b/test/firmware_delete_unittest.cpp
@@ -1,6 +1,7 @@
#include "data_mock.hpp"
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <sdbusplus/test/sdbus_mock.hpp>
#include <vector>
@@ -21,7 +22,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -35,18 +36,17 @@
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
std::move(bus_mock), blobs, data);
- EXPECT_CALL(imageMock, open(Eq(FirmwareBlobHandler::hashBlobID)))
- .WillOnce(Return(true));
+ EXPECT_CALL(imageMock, open(StrEq(hashBlobId))).WillOnce(Return(true));
EXPECT_TRUE(handler->open(
0, OpenFlags::write | FirmwareBlobHandler::UpdateFlags::ipmi,
- FirmwareBlobHandler::hashBlobID));
+ hashBlobId));
/* The active hash blob_id was added. */
auto currentBlobs = handler->getBlobIds();
EXPECT_EQ(4, currentBlobs.size());
EXPECT_EQ(1, std::count(currentBlobs.begin(), currentBlobs.end(),
- FirmwareBlobHandler::activeHashBlobID));
+ activeHashBlobId));
/* Set up close() expectations. */
EXPECT_CALL(imageMock, close());
@@ -55,15 +55,15 @@
currentBlobs = handler->getBlobIds();
EXPECT_EQ(4, currentBlobs.size());
EXPECT_EQ(1, std::count(currentBlobs.begin(), currentBlobs.end(),
- FirmwareBlobHandler::activeHashBlobID));
+ activeHashBlobId));
/* Delete the blob. */
- EXPECT_TRUE(handler->deleteBlob(FirmwareBlobHandler::activeHashBlobID));
+ EXPECT_TRUE(handler->deleteBlob(activeHashBlobId));
currentBlobs = handler->getBlobIds();
EXPECT_EQ(3, currentBlobs.size());
EXPECT_EQ(0, std::count(currentBlobs.begin(), currentBlobs.end(),
- FirmwareBlobHandler::activeHashBlobID));
+ activeHashBlobId));
}
} // namespace blobs
diff --git a/test/firmware_handler_unittest.cpp b/test/firmware_handler_unittest.cpp
index 1457a3b..020d7ff 100644
--- a/test/firmware_handler_unittest.cpp
+++ b/test/firmware_handler_unittest.cpp
@@ -1,5 +1,6 @@
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <algorithm>
#include <sdbusplus/test/sdbus_mock.hpp>
@@ -28,7 +29,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
@@ -58,16 +59,14 @@
std::move(bus_mock), blobs, data);
EXPECT_EQ(handler, nullptr);
- blobs.push_back({FirmwareBlobHandler::hashBlobID, &imageMock});
+ blobs.push_back({hashBlobId, &imageMock});
handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
std::move(bus_mock), blobs, data);
auto result = handler->getBlobIds();
EXPECT_EQ(3, result.size());
EXPECT_EQ(3, std::count(result.begin(), result.end(), "asdf") +
- std::count(result.begin(), result.end(),
- FirmwareBlobHandler::hashBlobID) +
- std::count(result.begin(), result.end(),
- FirmwareBlobHandler::verifyBlobID));
+ std::count(result.begin(), result.end(), hashBlobId) +
+ std::count(result.begin(), result.end(), verifyBlobId));
}
} // namespace blobs
diff --git a/test/firmware_open_unittest.cpp b/test/firmware_open_unittest.cpp
index c56d5d5..1820bb1 100644
--- a/test/firmware_open_unittest.cpp
+++ b/test/firmware_open_unittest.cpp
@@ -1,6 +1,7 @@
#include "data_mock.hpp"
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <sdbusplus/test/sdbus_mock.hpp>
#include <vector>
@@ -22,7 +23,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -44,7 +45,7 @@
auto currentBlobs = handler->getBlobIds();
EXPECT_EQ(4, currentBlobs.size());
EXPECT_EQ(1, std::count(currentBlobs.begin(), currentBlobs.end(),
- FirmwareBlobHandler::activeImageBlobID));
+ activeImageBlobId));
}
TEST(FirmwareHandlerOpenTest, OpenWithEverythingValidHashFile)
@@ -53,7 +54,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -66,18 +67,17 @@
auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
std::move(bus_mock), blobs, data);
- EXPECT_CALL(imageMock, open(Eq(FirmwareBlobHandler::hashBlobID)))
- .WillOnce(Return(true));
+ EXPECT_CALL(imageMock, open(StrEq(hashBlobId))).WillOnce(Return(true));
EXPECT_TRUE(handler->open(
0, OpenFlags::write | FirmwareBlobHandler::UpdateFlags::ipmi,
- FirmwareBlobHandler::hashBlobID));
+ hashBlobId));
/* The active hash blob_id was added. */
auto currentBlobs = handler->getBlobIds();
EXPECT_EQ(4, currentBlobs.size());
EXPECT_EQ(1, std::count(currentBlobs.begin(), currentBlobs.end(),
- FirmwareBlobHandler::activeHashBlobID));
+ activeHashBlobId));
}
TEST(FirmwareHandlerOpenTest, OpenWithDataHandlerAllSucceeds)
@@ -89,7 +89,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -104,18 +104,17 @@
std::move(bus_mock), blobs, data);
EXPECT_CALL(dataMock, open()).WillOnce(Return(true));
- EXPECT_CALL(imageMock, open(Eq(FirmwareBlobHandler::hashBlobID)))
- .WillOnce(Return(true));
+ EXPECT_CALL(imageMock, open(StrEq(hashBlobId))).WillOnce(Return(true));
EXPECT_TRUE(handler->open(
0, OpenFlags::write | FirmwareBlobHandler::UpdateFlags::lpc,
- FirmwareBlobHandler::hashBlobID));
+ hashBlobId));
/* The active hash blob_id was added. */
auto currentBlobs = handler->getBlobIds();
EXPECT_EQ(4, currentBlobs.size());
EXPECT_EQ(1, std::count(currentBlobs.begin(), currentBlobs.end(),
- FirmwareBlobHandler::activeHashBlobID));
+ activeHashBlobId));
}
TEST(FirmwareHandlerOpenTest, OpenWithDataHandlerReturnsFailure)
@@ -125,7 +124,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -143,7 +142,7 @@
EXPECT_FALSE(handler->open(
0, OpenFlags::write | FirmwareBlobHandler::UpdateFlags::lpc,
- FirmwareBlobHandler::hashBlobID));
+ hashBlobId));
/* The active hash blob_id was added. */
auto currentBlobs = handler->getBlobIds();
@@ -158,7 +157,7 @@
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
std::vector<DataHandlerPack> data = {
@@ -180,21 +179,20 @@
auto currentBlobs = handler->getBlobIds();
EXPECT_EQ(4, currentBlobs.size());
EXPECT_EQ(1, std::count(currentBlobs.begin(), currentBlobs.end(),
- FirmwareBlobHandler::activeImageBlobID));
+ activeImageBlobId));
/* Open the hash file (since we opened an image file). */
EXPECT_FALSE(handler->open(
1, OpenFlags::write | FirmwareBlobHandler::UpdateFlags::ipmi,
- FirmwareBlobHandler::hashBlobID));
+ hashBlobId));
EXPECT_TRUE(handler->close(0));
- EXPECT_CALL(imageMock1, open(StrEq(FirmwareBlobHandler::hashBlobID)))
- .WillOnce(Return(true));
+ EXPECT_CALL(imageMock1, open(StrEq(hashBlobId))).WillOnce(Return(true));
EXPECT_TRUE(handler->open(
1, OpenFlags::write | FirmwareBlobHandler::UpdateFlags::ipmi,
- FirmwareBlobHandler::hashBlobID));
+ hashBlobId));
}
TEST(FirmwareHandlerOpenTest, OpenEverythingSucceedsOpenActiveFails)
@@ -207,7 +205,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -229,7 +227,7 @@
auto currentBlobs = handler->getBlobIds();
EXPECT_EQ(4, currentBlobs.size());
EXPECT_EQ(1, std::count(currentBlobs.begin(), currentBlobs.end(),
- FirmwareBlobHandler::activeImageBlobID));
+ activeImageBlobId));
/* Close only active session, to verify it's failing on attempt to open a
* specific blob_id.
@@ -238,7 +236,7 @@
EXPECT_FALSE(handler->open(
1, OpenFlags::write | FirmwareBlobHandler::UpdateFlags::ipmi,
- FirmwareBlobHandler::activeImageBlobID));
+ activeImageBlobId));
}
TEST(FirmwareHandlerOpenTest, OpenWithEverythingValidImageHandlerFails)
@@ -249,7 +247,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -279,7 +277,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -303,7 +301,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
@@ -327,7 +325,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
diff --git a/test/firmware_sessionstat_unittest.cpp b/test/firmware_sessionstat_unittest.cpp
index 4f6584f..e395358 100644
--- a/test/firmware_sessionstat_unittest.cpp
+++ b/test/firmware_sessionstat_unittest.cpp
@@ -1,6 +1,7 @@
#include "data_mock.hpp"
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <sdbusplus/test/sdbus_mock.hpp>
#include <vector>
@@ -19,7 +20,7 @@
*/
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
@@ -57,7 +58,7 @@
*/
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
diff --git a/test/firmware_stat_unittest.cpp b/test/firmware_stat_unittest.cpp
index d6cc99d..4c90735 100644
--- a/test/firmware_stat_unittest.cpp
+++ b/test/firmware_stat_unittest.cpp
@@ -1,5 +1,6 @@
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <sdbusplus/test/sdbus_mock.hpp>
#include <vector>
@@ -20,7 +21,7 @@
ImageHandlerMock imageMock;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock},
+ {hashBlobId, &imageMock},
{"asdf", &imageMock},
};
std::vector<DataHandlerPack> data = {
diff --git a/test/firmware_write_unittest.cpp b/test/firmware_write_unittest.cpp
index d9fcae4..6ba2081 100644
--- a/test/firmware_write_unittest.cpp
+++ b/test/firmware_write_unittest.cpp
@@ -1,6 +1,7 @@
#include "data_mock.hpp"
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <cstdint>
#include <cstring>
@@ -20,7 +21,7 @@
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
@@ -51,7 +52,7 @@
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
@@ -94,7 +95,7 @@
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
diff --git a/test/firmware_writemeta_unittest.cpp b/test/firmware_writemeta_unittest.cpp
index 4e8cd45..ad7f25b 100644
--- a/test/firmware_writemeta_unittest.cpp
+++ b/test/firmware_writemeta_unittest.cpp
@@ -1,6 +1,7 @@
#include "data_mock.hpp"
#include "firmware_handler.hpp"
#include "image_mock.hpp"
+#include "util.hpp"
#include <sdbusplus/test/sdbus_mock.hpp>
@@ -15,7 +16,7 @@
{
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
@@ -46,7 +47,7 @@
{
ImageHandlerMock imageMock1, imageMock2;
std::vector<HandlerPack> blobs = {
- {FirmwareBlobHandler::hashBlobID, &imageMock1},
+ {hashBlobId, &imageMock1},
{"asdf", &imageMock2},
};
diff --git a/test/tools_updater_unittest.cpp b/test/tools_updater_unittest.cpp
index 31c8d55..080671f 100644
--- a/test/tools_updater_unittest.cpp
+++ b/test/tools_updater_unittest.cpp
@@ -1,6 +1,7 @@
#include "data_interface_mock.hpp"
#include "updater.hpp"
#include "updater_mock.hpp"
+#include "util.hpp"
#include <blobs-ipmid/blobs.hpp>
#include <ipmiblob/test/blob_interface_mock.hpp>
@@ -23,23 +24,23 @@
DataInterfaceMock handlerMock;
ipmiblob::BlobInterfaceMock blobMock;
- std::string expectedBlob = "/flash/image";
-
ipmiblob::StatResponse statObj;
statObj.blob_state = blobs::FirmwareBlobHandler::UpdateFlags::ipmi |
blobs::FirmwareBlobHandler::UpdateFlags::lpc;
statObj.size = 0;
EXPECT_CALL(blobMock, getBlobList())
- .WillOnce(Return(std::vector<std::string>({expectedBlob})));
- EXPECT_CALL(blobMock, getStat(TypedEq<const std::string&>(expectedBlob)))
+ .WillOnce(
+ Return(std::vector<std::string>({blobs::staticLayoutBlobId})));
+ EXPECT_CALL(blobMock,
+ getStat(TypedEq<const std::string&>(blobs::staticLayoutBlobId)))
.WillOnce(Return(statObj));
EXPECT_CALL(handlerMock, supportedType())
.WillOnce(Return(blobs::FirmwareBlobHandler::UpdateFlags::lpc));
UpdateHandler updater(&blobMock, &handlerMock);
- EXPECT_TRUE(updater.checkAvailable(expectedBlob));
+ EXPECT_TRUE(updater.checkAvailable(blobs::staticLayoutBlobId));
}
TEST(UpdaterTest, SendFileSuccess)
@@ -48,7 +49,6 @@
DataInterfaceMock handlerMock;
ipmiblob::BlobInterfaceMock blobMock;
- std::string expectedBlob = "/flash/image";
std::string firmwareImage = "image.bin";
std::uint16_t supported =
@@ -60,7 +60,8 @@
EXPECT_CALL(handlerMock, supportedType())
.WillOnce(Return(blobs::FirmwareBlobHandler::UpdateFlags::lpc));
- EXPECT_CALL(blobMock, openBlob(StrEq(expectedBlob.c_str()), supported))
+ EXPECT_CALL(blobMock,
+ openBlob(StrEq(blobs::staticLayoutBlobId.c_str()), supported))
.WillOnce(Return(session));
EXPECT_CALL(handlerMock,
@@ -70,7 +71,7 @@
EXPECT_CALL(blobMock, closeBlob(session)).Times(1);
UpdateHandler updater(&blobMock, &handlerMock);
- updater.sendFile(expectedBlob, firmwareImage);
+ updater.sendFile(blobs::staticLayoutBlobId, firmwareImage);
}
#if 0 /* TODO: fix this up. */
@@ -84,11 +85,8 @@
std::string firmwareImage = "image.bin";
std::string signatureFile = "image.sig";
- std::string expectedBlob = "/flash/image";
- std::string expectedHash = "/flash/hash";
- std::string expectedVerify = "/flash/verify";
- std::vector<std::string> blobList = {expectedBlob};
+ std::vector<std::string> blobList = {blobs::staticLayoutBlobId};
ipmiblob::StatResponse statObj;
statObj.blob_state = blobs::FirmwareBlobHandler::UpdateFlags::ipmi |
blobs::FirmwareBlobHandler::UpdateFlags::lpc;
@@ -101,20 +99,20 @@
EXPECT_CALL(blobMock, getBlobList()).WillOnce(Return(blobList));
- EXPECT_CALL(blobMock, getStat(TypedEq<const std::string&>(expectedBlob)))
+ EXPECT_CALL(blobMock, getStat(TypedEq<const std::string&>(blobs::staticLayoutBlobId)))
.WillOnce(Return(statObj));
EXPECT_CALL(handlerMock, supportedType())
.WillOnce(Return(blobs::FirmwareBlobHandler::UpdateFlags::lpc));
- EXPECT_CALL(blobMock, openBlob(StrEq(expectedBlob.c_str()), Eq(supported)))
+ EXPECT_CALL(blobMock, openBlob(StrEq(blobs::staticLayoutBlobId.c_str()), Eq(supported)))
.WillOnce(Return(session));
EXPECT_CALL(handlerMock,
sendContents(StrEq(firmwareImage.c_str()), Eq(session)))
.WillOnce(Return(true));
- EXPECT_CALL(blobMock, openBlob(StrEq(expectedHash.c_str()), Eq(supported)))
+ EXPECT_CALL(blobMock, openBlob(StrEq(blobs::hashBlobId.c_str()), Eq(supported)))
.WillOnce(Return(session));
EXPECT_CALL(handlerMock,
@@ -122,7 +120,7 @@
.WillOnce(Return(true));
EXPECT_CALL(blobMock,
- openBlob(StrEq(expectedVerify.c_str()), Eq(supported)))
+ openBlob(StrEq(blobs::verifyBlobId.c_str()), Eq(supported)))
.WillOnce(Return(session));
EXPECT_CALL(blobMock, commit(session, _)).WillOnce(Return());