commit 7ef1346f9ee8f35094a8d2ef02de499cce9720d8
author Patrick Venture <venture@google.com> Fri Feb 01 15:24:41 2019 -0800
committer Patrick Venture <venture@google.com> Mon Feb 04 10:14:52 2019 -0800
tree 28eaeded21fc549279f001317470c7980e3fc3e1
parent 957f086e4398a2d34e809df45c7ced4fe37357cd

tools: blob_handler: add some const ness

Many pointers cast that should be const by use-case were missing this.

Change-Id: Ib75a210d731d731ef07f59d4132f70e5cfd324bf
Signed-off-by: Patrick Venture <venture@google.com>

tools/blob_handler.cpp

diff --git a/tools/blob_handler.cpp b/tools/blob_handler.cpp
index 081c32f..12fbaaa 100644
--- a/tools/blob_handler.cpp
+++ b/tools/blob_handler.cpp
@@ -48,7 +48,7 @@
 
         /* CRC required. */
         std::uint16_t crc = generateCrc(payload);
-        std::uint8_t* src = reinterpret_cast<std::uint8_t*>(&crc);
+        auto src = reinterpret_cast<const std::uint8_t*>(&crc);
 
         std::copy(src, src + sizeof(crc), std::back_inserter(request));
 
@@ -145,7 +145,7 @@
 std::string BlobHandler::enumerateBlob(std::uint32_t index)
 {
     std::vector<std::uint8_t> payload;
-    std::uint8_t* data = reinterpret_cast<std::uint8_t*>(&index);
+    auto data = reinterpret_cast<const std::uint8_t*>(&index);
 
     std::copy(data, data + sizeof(std::uint32_t), std::back_inserter(payload));
 
@@ -170,10 +170,10 @@
     payload.reserve(sizeof(std::uint16_t) + sizeof(std::uint32_t) +
                     bytes.size());
 
-    std::uint8_t* data = reinterpret_cast<std::uint8_t*>(&session);
+    auto data = reinterpret_cast<const std::uint8_t*>(&session);
     std::copy(data, data + sizeof(std::uint16_t), std::back_inserter(payload));
 
-    data = reinterpret_cast<std::uint8_t*>(&offset);
+    data = reinterpret_cast<const std::uint8_t*>(&offset);
     std::copy(data, data + sizeof(std::uint32_t), std::back_inserter(payload));
 
     std::copy(bytes.begin(), bytes.end(), std::back_inserter(payload));
@@ -250,7 +250,7 @@
     std::vector<std::uint8_t> request, resp;
     std::uint16_t flags =
         blobs::FirmwareBlobHandler::UpdateFlags::openWrite | handlerFlags;
-    auto addrFlags = reinterpret_cast<std::uint8_t*>(&flags);
+    auto addrFlags = reinterpret_cast<const std::uint8_t*>(&flags);
 
     std::copy(addrFlags, addrFlags + sizeof(flags),
               std::back_inserter(request));
@@ -278,7 +278,7 @@
 void BlobHandler::closeBlob(std::uint16_t session)
 {
     std::vector<std::uint8_t> request, resp;
-    auto addrSession = reinterpret_cast<std::uint8_t*>(&session);
+    auto addrSession = reinterpret_cast<const std::uint8_t*>(&session);
     std::copy(addrSession, addrSession + sizeof(session),
               std::back_inserter(request));
 
@@ -303,13 +303,13 @@
     payload.reserve(sizeof(std::uint16_t) + sizeof(std::uint32_t) +
                     sizeof(std::uint32_t));
 
-    std::uint8_t* data = reinterpret_cast<std::uint8_t*>(&session);
+    auto data = reinterpret_cast<const std::uint8_t*>(&session);
     std::copy(data, data + sizeof(std::uint16_t), std::back_inserter(payload));
 
-    data = reinterpret_cast<std::uint8_t*>(&offset);
+    data = reinterpret_cast<const std::uint8_t*>(&offset);
     std::copy(data, data + sizeof(std::uint32_t), std::back_inserter(payload));
 
-    data = reinterpret_cast<std::uint8_t*>(&length);
+    data = reinterpret_cast<const std::uint8_t*>(&length);
     std::copy(data, data + sizeof(std::uint32_t), std::back_inserter(payload));
 
     return sendIpmiPayload(BlobOEMCommands::bmcBlobRead, payload);