bmc: add verify blob id only when ready
Originally, the verify blob id was always present. Now, it's only added
when the state transitions initially to verificationPending.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I706273519354a7a4a98d9fe4f600c6455a69cc3c
diff --git a/test/firmware_state_notyetstarted_unittest.cpp b/test/firmware_state_notyetstarted_unittest.cpp
index a97a348..bdfffcb 100644
--- a/test/firmware_state_notyetstarted_unittest.cpp
+++ b/test/firmware_state_notyetstarted_unittest.cpp
@@ -50,8 +50,7 @@
/* TODO: Presently, /flash/verify is present from the beginning, however,
* this is going to change to simplify handling of open().
*/
- std::vector<std::string> expectedBlobs = {staticLayoutBlobId, hashBlobId,
- verifyBlobId};
+ std::vector<std::string> expectedBlobs = {staticLayoutBlobId, hashBlobId};
EXPECT_THAT(handler->getBlobIds(),
UnorderedElementsAreArray(expectedBlobs));
@@ -76,11 +75,8 @@
expected.blobState = FirmwareBlobHandler::UpdateFlags::ipmi;
expected.size = 0;
- /* TODO: note, once verifyblobid isn't present in this state we can use
- * getblobids()'s output as input
- */
- std::vector<std::string> testBlobs = {staticLayoutBlobId, hashBlobId};
- for (const auto& blob : testBlobs)
+ auto blobs = handler->getBlobIds();
+ for (const auto& blob : blobs)
{
blobs::BlobMeta meta = {};
EXPECT_TRUE(handler->stat(blob, &meta));