lpc_aspeed: add todo describing correct mmap
Currently the mmap call for the lpc_aspeed module is incorrect. It
should be offset by the difference between the address and the memory
region base address in the device-tree.
Change-Id: I6e459b39ef1e9389e0048cfeb97344343512487e
Signed-off-by: Patrick Venture <venture@google.com>
diff --git a/lpc_aspeed.cpp b/lpc_aspeed.cpp
index 9d09858..73ce315 100644
--- a/lpc_aspeed.cpp
+++ b/lpc_aspeed.cpp
@@ -118,6 +118,9 @@
/* Open the file to map. */
mappedFd = sys->open(lpcControlPath.c_str(), O_RDONLY | O_SYNC);
+ /* TODO: The offset to use is the address we use for the map - the base
+ * address of the memory region we reserved in the device-tree.
+ */
mappedRegion = reinterpret_cast<uint8_t*>(
sys->mmap(0, regionSize, PROT_READ, MAP_SHARED, mappedFd, 0));