commit ad7c73df7ebf5e28c77902aae17b18042a851ca3
author Patrick Venture <venture@google.com> Fri May 17 18:50:27 2019 -0700
committer Patrick Venture <venture@google.com> Fri May 17 19:04:19 2019 -0700
tree 2237d4a826598eae58cae697952861ae11866d06
parent eb5df1481a3c88908431cfb0d5defc82fea2b2e2

test: cleanup: firmware::writemeta() tests

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I550326bfb2416286312375c016fd96232c733a83

test/firmware_writemeta_unittest.cpp

diff --git a/test/firmware_writemeta_unittest.cpp b/test/firmware_writemeta_unittest.cpp
index 3441a14..93887d2 100644
--- a/test/firmware_writemeta_unittest.cpp
+++ b/test/firmware_writemeta_unittest.cpp
@@ -4,6 +4,9 @@
 #include "util.hpp"
 #include "verification_mock.hpp"
 
+#include <memory>
+#include <vector>
+
 #include <gtest/gtest.h>
 
 namespace blobs
@@ -11,24 +14,32 @@
 using ::testing::Eq;
 using ::testing::Return;
 
-TEST(FirmwareHandlerWriteMetaTest, WriteConfigParametersFailIfOverIPMI)
+class FirmwareHandlerWriteMetaTest : public ::testing::Test
 {
-    ImageHandlerMock imageMock1, imageMock2;
-    std::vector<HandlerPack> blobs = {
-        {hashBlobId, &imageMock1},
-        {"asdf", &imageMock2},
-    };
-
+  protected:
     DataHandlerMock dataMock;
+    ImageHandlerMock imageMock1, imageMock2;
+    std::vector<HandlerPack> blobs;
+    std::vector<DataHandlerPack> data;
+    std::unique_ptr<GenericBlobInterface> handler;
 
-    std::vector<DataHandlerPack> data = {
-        {FirmwareBlobHandler::UpdateFlags::ipmi, nullptr},
-        {FirmwareBlobHandler::UpdateFlags::lpc, &dataMock},
-    };
+    void SetUp() override
+    {
+        blobs = {
+            {hashBlobId, &imageMock1},
+            {"asdf", &imageMock2},
+        };
+        data = {
+            {FirmwareBlobHandler::UpdateFlags::ipmi, nullptr},
+            {FirmwareBlobHandler::UpdateFlags::lpc, &dataMock},
+        };
+        handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
+            blobs, data, CreateVerifyMock());
+    }
+};
 
-    auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
-        blobs, data, CreateVerifyMock());
-
+TEST_F(FirmwareHandlerWriteMetaTest, WriteConfigParametersFailIfOverIPMI)
+{
     EXPECT_CALL(imageMock2, open("asdf")).WillOnce(Return(true));
 
     EXPECT_TRUE(handler->open(
@@ -39,24 +50,8 @@
     EXPECT_FALSE(handler->writeMeta(0, 0, bytes));
 }
 
-TEST(FirmwareHandlerWriteMetaTest, WriteConfigParametersPassedThrough)
+TEST_F(FirmwareHandlerWriteMetaTest, WriteConfigParametersPassedThrough)
 {
-    ImageHandlerMock imageMock1, imageMock2;
-    std::vector<HandlerPack> blobs = {
-        {hashBlobId, &imageMock1},
-        {"asdf", &imageMock2},
-    };
-
-    DataHandlerMock dataMock;
-
-    std::vector<DataHandlerPack> data = {
-        {FirmwareBlobHandler::UpdateFlags::ipmi, nullptr},
-        {FirmwareBlobHandler::UpdateFlags::lpc, &dataMock},
-    };
-
-    auto handler = FirmwareBlobHandler::CreateFirmwareBlobHandler(
-        blobs, data, CreateVerifyMock());
-
     EXPECT_CALL(dataMock, open()).WillOnce(Return(true));
     EXPECT_CALL(imageMock2, open("asdf")).WillOnce(Return(true));