commit ae0941a965985e34cf587620ff19a3180be45e0c
author Patrick Venture <venture@google.com> Wed Jun 26 11:51:33 2019 -0700
committer Patrick Venture <venture@google.com> Wed Jun 26 11:55:20 2019 -0700
tree 2d50cdefb1c94e62315d98a561b3a3c72b703dc7
parent 7c79b252c11f0d5fb711c1af5384719d49aea45e

bmc: lpc aspeed: add missing file open failure check

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I5440b54cb5b24618c8cf5d6a4d977a82f5b704dd

lpc_aspeed.cpp

diff --git a/lpc_aspeed.cpp b/lpc_aspeed.cpp
index 7f111f2..364aff5 100644
--- a/lpc_aspeed.cpp
+++ b/lpc_aspeed.cpp
@@ -140,10 +140,13 @@
 {
     /* Open the file to map. */
     mappedFd = sys->open(lpcControlPath.c_str(), O_RDONLY | O_SYNC);
+    if (mappedFd == -1)
+    {
+        std::fprintf(stderr, "ipmiflash: unable to open %s\n",
+                     lpcControlPath.c_str());
+        return false;
+    }
 
-    /* TODO: The offset to use is the address we use for the map - the base
-     * address of the memory region we reserved in the device-tree.
-     */
     mappedRegion = reinterpret_cast<uint8_t*>(
         sys->mmap(0, regionSize, PROT_READ, MAP_SHARED, mappedFd, 0));