test: firmware verificationPending: open
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If6df9aea5a982c38bec50b6fe27200466f307188
diff --git a/test/firmware_state_verificationpending_unittest.cpp b/test/firmware_state_verificationpending_unittest.cpp
index 2f22291..594bd2b 100644
--- a/test/firmware_state_verificationpending_unittest.cpp
+++ b/test/firmware_state_verificationpending_unittest.cpp
@@ -62,7 +62,6 @@
/*
* getBlobIds
*/
-
TEST_F(FirmwareHandlerVerificationPendingTest, VerifyBlobIdAvailableInState)
{
/* Only in the verificationPending state (and later), should the
@@ -125,11 +124,43 @@
}
/*
- * stat(session)
- */
-/*
* open(blob)
*/
+TEST_F(FirmwareHandlerVerificationPendingTest, OpenVerifyBlobSucceeds)
+{
+ getToVerificationPending(staticLayoutBlobId);
+
+ /* the session is safe because it was already closed to get to this state.
+ */
+ EXPECT_TRUE(handler->open(session, flags, verifyBlobId));
+}
+
+TEST_F(FirmwareHandlerVerificationPendingTest, OpenActiveImageBlobFails)
+{
+ /* Try opening the active blob Id. This test is equivalent to trying to
+ * open the active hash blob id, in that neither are ever allowed.
+ */
+ getToVerificationPending(staticLayoutBlobId);
+ EXPECT_FALSE(handler->open(session, flags, activeImageBlobId));
+}
+
+TEST_F(FirmwareHandlerVerificationPendingTest,
+ OpenImageBlobTransitionsToUploadInProgress)
+{
+ getToVerificationPending(staticLayoutBlobId);
+ EXPECT_CALL(imageMock, open(staticLayoutBlobId)).WillOnce(Return(true));
+ EXPECT_TRUE(handler->open(session, flags, staticLayoutBlobId));
+
+ auto realHandler = dynamic_cast<FirmwareBlobHandler*>(handler.get());
+ EXPECT_EQ(FirmwareBlobHandler::UpdateState::uploadInProgress,
+ realHandler->getCurrentState());
+}
+
+/*
+ * stat(session) - in this state, you can only open(verifyBlobId) without
+ * changing state.
+ */
+
/*
* close(session)
*/