commit eb5df1481a3c88908431cfb0d5defc82fea2b2e2
author Patrick Venture <venture@google.com> Fri May 17 18:43:36 2019 -0700
committer Patrick Venture <venture@google.com> Fri May 17 19:04:19 2019 -0700
tree 2db29fb0039fbeecfb2eb3ef2a70d3eac0ec763c
parent 6f09ff5b79d1b54d06193a37283e8a65909125b4

test: cleanup: firmware::write() tests

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1a186b0491152f9919de2e9dd43cb68d7de29bda

test/firmware_write_unittest.cpp

diff --git a/test/firmware_write_unittest.cpp b/test/firmware_write_unittest.cpp
index 72ffcb3..48c3217 100644
--- a/test/firmware_write_unittest.cpp
+++ b/test/firmware_write_unittest.cpp
@@ -15,16 +15,24 @@
 using ::testing::Eq;
 using ::testing::Return;
 
-TEST(FirmwareHandlerWriteTest, DataTypeIpmiWriteSuccess)
+class FirmwareHandlerWriteTest : public ::testing::Test
+{
+  protected:
+    ImageHandlerMock imageMock1, imageMock2;
+    std::vector<HandlerPack> blobs;
+
+    void SetUp() override
+    {
+        blobs = {
+            {hashBlobId, &imageMock1},
+            {"asdf", &imageMock2},
+        };
+    }
+};
+
+TEST_F(FirmwareHandlerWriteTest, DataTypeIpmiWriteSuccess)
 {
     /* Verify if data type ipmi, it calls write with the bytes. */
-
-    ImageHandlerMock imageMock1, imageMock2;
-    std::vector<HandlerPack> blobs = {
-        {hashBlobId, &imageMock1},
-        {"asdf", &imageMock2},
-    };
-
     std::vector<DataHandlerPack> data = {
         {FirmwareBlobHandler::UpdateFlags::ipmi, nullptr},
     };
@@ -43,16 +51,9 @@
     EXPECT_TRUE(handler->write(0, 0, bytes));
 }
 
-TEST(FirmwareHandlerWriteTest, DataTypeNonIpmiWriteSuccess)
+TEST_F(FirmwareHandlerWriteTest, DataTypeNonIpmiWriteSuccess)
 {
     /* Verify if data type non-ipmi, it calls write with the length. */
-
-    ImageHandlerMock imageMock1, imageMock2;
-    std::vector<HandlerPack> blobs = {
-        {hashBlobId, &imageMock1},
-        {"asdf", &imageMock2},
-    };
-
     DataHandlerMock dataMock;
 
     std::vector<DataHandlerPack> data = {
@@ -82,17 +83,10 @@
     EXPECT_TRUE(handler->write(0, 0, ipmiRequest));
 }
 
-TEST(FirmwareHandlerWriteTest, DataTypeNonIpmiWriteFailsBadRequest)
+TEST_F(FirmwareHandlerWriteTest, DataTypeNonIpmiWriteFailsBadRequest)
 {
     /* Verify the data type non-ipmi, if the request's structure doesn't match,
      * return failure. */
-
-    ImageHandlerMock imageMock1, imageMock2;
-    std::vector<HandlerPack> blobs = {
-        {hashBlobId, &imageMock1},
-        {"asdf", &imageMock2},
-    };
-
     DataHandlerMock dataMock;
 
     std::vector<DataHandlerPack> data = {