commit fbc7d191eb6d49ff93379e90f372960b799b25c4
author Patrick Venture <venture@google.com> Fri Aug 03 13:54:21 2018 -0700
committer Patrick Venture <venture@google.com> Tue Aug 07 10:11:02 2018 -0700
tree 935508a2e4bb81e6dae10a7a421d5112e195be22
parent cfe66877a5d7cc64bcce5c8789ca164edf9f1c56

ipmi: start implementing flashHashFinish

Change-Id: I354b346bcd2d0dd141fd21a84e57cd7c06eadc1a
Signed-off-by: Patrick Venture <venture@google.com>

test/Makefile.am

diff --git a/test/Makefile.am b/test/Makefile.am
index 392db5c..350c3a8 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -15,6 +15,7 @@
 	ipmi_flashfinish_unittest \
 	ipmi_starthash_unittest \
 	ipmi_hashdata_unittest \
+	ipmi_hashfinish_unittest \
 	ipmi_validate_unittest
 
 TESTS = $(check_PROGRAMS)
@@ -34,5 +35,8 @@
 ipmi_hashdata_unittest_SOURCES = ipmi_hashdata_unittest.cpp
 ipmi_hashdata_unittest_LDADD = $(top_builddir)/ipmi.o
 
+ipmi_hashfinish_unittest_SOURCES = ipmi_hashfinish_unittest.cpp
+ipmi_hashfinish_unittest_LDADD = $(top_builddir)/ipmi.o
+
 ipmi_validate_unittest_SOURCES = ipmi_validate_unittest.cpp
 ipmi_validate_unittest_LDADD = $(top_builddir)/ipmi.o

test/ipmi_hashfinish_unittest.cpp

diff --git a/test/ipmi_hashfinish_unittest.cpp b/test/ipmi_hashfinish_unittest.cpp
new file mode 100644
index 0000000..006525d
--- /dev/null
+++ b/test/ipmi_hashfinish_unittest.cpp
@@ -0,0 +1,34 @@
+#include "flash-ipmi.hpp"
+#include "ipmi.hpp"
+
+#include "updater_mock.hpp"
+
+#include <cstring>
+#include <gtest/gtest.h>
+
+using ::testing::Return;
+using ::testing::StrictMock;
+
+// ipmid.hpp isn't installed where we can grab it and this value is per BMC
+// SoC.
+#define MAX_IPMI_BUFFER 64
+
+TEST(IpmiHashFinish, CallPassedOn)
+{
+    // The data finish command does no validation as the input is empty, and
+    // simply relies on the flash manager to do work.
+
+    StrictMock<UpdaterMock> updater;
+
+    size_t dataLen;
+    uint8_t request[MAX_IPMI_BUFFER] = {0};
+    uint8_t reply[MAX_IPMI_BUFFER] = {0};
+
+    dataLen = 1; // request is only the command.
+    request[0] = FlashSubCmds::flashHashFinish;
+
+    EXPECT_CALL(updater, hashFinish()).WillOnce(Return(true));
+    EXPECT_EQ(IPMI_CC_OK, hashFinish(&updater, request, reply, &dataLen));
+    EXPECT_EQ(sizeof(uint8_t), dataLen);
+    EXPECT_EQ(0, reply[0]);
+}

test/updater_mock.hpp

diff --git a/test/updater_mock.hpp b/test/updater_mock.hpp
index 1e03a31..fa912ea 100644
--- a/test/updater_mock.hpp
+++ b/test/updater_mock.hpp
@@ -15,4 +15,5 @@
     MOCK_METHOD0(flashFinish, bool());
     MOCK_METHOD1(startHash, bool(uint32_t));
     MOCK_METHOD2(hashData, bool(uint32_t, const std::vector<uint8_t>&));
+    MOCK_METHOD0(hashFinish, bool());
 };