Patrick Venture | 22e3875 | 2018-11-21 08:52:49 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2018 Google Inc. |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 17 | #include "firmware_handler.hpp" |
| 18 | |
Patrick Venture | a78e39f | 2018-11-06 18:37:06 -0800 | [diff] [blame] | 19 | #include "image_handler.hpp" |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 20 | #include "util.hpp" |
Patrick Venture | 26a1726 | 2019-05-20 11:03:35 -0700 | [diff] [blame] | 21 | #include "verify.hpp" |
Patrick Venture | a78e39f | 2018-11-06 18:37:06 -0800 | [diff] [blame] | 22 | |
Patrick Venture | 137ad2c | 2018-11-06 11:30:43 -0800 | [diff] [blame] | 23 | #include <algorithm> |
Patrick Venture | 192d60f | 2018-11-06 11:11:59 -0800 | [diff] [blame] | 24 | #include <cstdint> |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 25 | #include <cstring> |
Patrick Venture | b3b4db7 | 2019-05-15 11:30:24 -0700 | [diff] [blame] | 26 | #include <fstream> |
Patrick Venture | 68cf64f | 2018-11-06 10:46:51 -0800 | [diff] [blame] | 27 | #include <memory> |
Patrick Venture | d333a87 | 2018-12-03 16:24:26 -0800 | [diff] [blame] | 28 | #include <phosphor-logging/log.hpp> |
Patrick Venture | fa6c4d9 | 2018-11-02 18:34:53 -0700 | [diff] [blame] | 29 | #include <string> |
| 30 | #include <vector> |
| 31 | |
Patrick Venture | d333a87 | 2018-12-03 16:24:26 -0800 | [diff] [blame] | 32 | using namespace phosphor::logging; |
| 33 | |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 34 | namespace ipmi_flash |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 35 | { |
Patrick Venture | b3b4db7 | 2019-05-15 11:30:24 -0700 | [diff] [blame] | 36 | |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 37 | std::unique_ptr<blobs::GenericBlobInterface> |
Patrick Venture | 148cd65 | 2018-11-06 10:59:47 -0800 | [diff] [blame] | 38 | FirmwareBlobHandler::CreateFirmwareBlobHandler( |
Patrick Venture | 3ecb350 | 2019-05-17 11:03:51 -0700 | [diff] [blame] | 39 | const std::vector<HandlerPack>& firmwares, |
Patrick Venture | 74059d6 | 2019-05-17 10:40:26 -0700 | [diff] [blame] | 40 | const std::vector<DataHandlerPack>& transports, |
Patrick Venture | 27ac582 | 2019-05-20 17:39:31 -0700 | [diff] [blame] | 41 | std::unique_ptr<VerificationInterface> verification, |
| 42 | std::unique_ptr<UpdateInterface> update) |
Patrick Venture | 68cf64f | 2018-11-06 10:46:51 -0800 | [diff] [blame] | 43 | { |
Patrick Venture | 5285462 | 2018-11-06 12:30:00 -0800 | [diff] [blame] | 44 | /* There must be at least one. */ |
| 45 | if (!firmwares.size()) |
| 46 | { |
Patrick Venture | d333a87 | 2018-12-03 16:24:26 -0800 | [diff] [blame] | 47 | log<level::ERR>("Must provide at least one firmware handler."); |
Patrick Venture | 5285462 | 2018-11-06 12:30:00 -0800 | [diff] [blame] | 48 | return nullptr; |
| 49 | } |
Patrick Venture | 1cde5f9 | 2018-11-07 08:26:47 -0800 | [diff] [blame] | 50 | if (!transports.size()) |
| 51 | { |
| 52 | return nullptr; |
| 53 | } |
Patrick Venture | 5285462 | 2018-11-06 12:30:00 -0800 | [diff] [blame] | 54 | |
Patrick Venture | a78e39f | 2018-11-06 18:37:06 -0800 | [diff] [blame] | 55 | std::vector<std::string> blobs; |
| 56 | for (const auto& item : firmwares) |
| 57 | { |
| 58 | blobs.push_back(item.blobName); |
| 59 | } |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 60 | |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 61 | if (0 == std::count(blobs.begin(), blobs.end(), hashBlobId)) |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 62 | { |
| 63 | return nullptr; |
| 64 | } |
Patrick Venture | 4cceb8e | 2018-11-06 11:56:48 -0800 | [diff] [blame] | 65 | |
Patrick Venture | 1cde5f9 | 2018-11-07 08:26:47 -0800 | [diff] [blame] | 66 | std::uint16_t bitmask = 0; |
| 67 | for (const auto& item : transports) |
| 68 | { |
| 69 | /* TODO: can use std::accumulate() unless I'm mistaken. :D */ |
| 70 | bitmask |= item.bitmask; |
| 71 | } |
| 72 | |
Patrick Venture | 3ecb350 | 2019-05-17 11:03:51 -0700 | [diff] [blame] | 73 | return std::make_unique<FirmwareBlobHandler>( |
Patrick Venture | 27ac582 | 2019-05-20 17:39:31 -0700 | [diff] [blame] | 74 | firmwares, blobs, transports, bitmask, std::move(verification), |
| 75 | std::move(update)); |
Patrick Venture | 68cf64f | 2018-11-06 10:46:51 -0800 | [diff] [blame] | 76 | } |
| 77 | |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 78 | /* Check if the path is in our supported list (or active list). */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 79 | bool FirmwareBlobHandler::canHandleBlob(const std::string& path) |
| 80 | { |
Patrick Venture | 6032dc0 | 2019-05-17 11:01:44 -0700 | [diff] [blame] | 81 | return (std::count(blobIDs.begin(), blobIDs.end(), path) > 0); |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 82 | } |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 83 | |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 84 | /* |
| 85 | * Grab the list of supported firmware. |
| 86 | * |
| 87 | * If there's an open firmware session, it'll already be present in the |
| 88 | * list as "/flash/active/image", and if the hash has started, |
| 89 | * "/flash/active/hash" regardless of mechanism. This is done in the open |
| 90 | * comamnd, no extra work is required here. |
| 91 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 92 | std::vector<std::string> FirmwareBlobHandler::getBlobIds() |
| 93 | { |
Patrick Venture | 4cceb8e | 2018-11-06 11:56:48 -0800 | [diff] [blame] | 94 | return blobIDs; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 95 | } |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 96 | |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 97 | /* |
| 98 | * Per the design, this mean abort, and this will trigger whatever |
| 99 | * appropriate actions are required to abort the process. |
Patrick Venture | 9e5aab2 | 2018-11-09 20:49:28 -0800 | [diff] [blame] | 100 | * |
| 101 | * You cannot delete a blob that has an open handle in the system, therefore |
| 102 | * this is never called if there's an open session. Guaranteed by the blob |
| 103 | * manager. |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 104 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 105 | bool FirmwareBlobHandler::deleteBlob(const std::string& path) |
| 106 | { |
Patrick Venture | 9e5aab2 | 2018-11-09 20:49:28 -0800 | [diff] [blame] | 107 | const std::string* toDelete; |
| 108 | |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 109 | /* You cannot delete the verify blob -- trying to delete it, currently has |
| 110 | * no impact. |
| 111 | * TODO: Should trying to delete this cause an abort? |
| 112 | */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 113 | if (path == verifyBlobId) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 114 | { |
| 115 | return false; |
| 116 | } |
| 117 | |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 118 | if (path == hashBlobId || path == activeHashBlobId) |
Patrick Venture | 9e5aab2 | 2018-11-09 20:49:28 -0800 | [diff] [blame] | 119 | { |
| 120 | /* They're deleting the hash. */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 121 | toDelete = &activeHashBlobId; |
Patrick Venture | 9e5aab2 | 2018-11-09 20:49:28 -0800 | [diff] [blame] | 122 | } |
| 123 | else |
| 124 | { |
| 125 | /* They're deleting the image. */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 126 | toDelete = &activeImageBlobId; |
Patrick Venture | 9e5aab2 | 2018-11-09 20:49:28 -0800 | [diff] [blame] | 127 | } |
| 128 | |
| 129 | auto it = std::find_if( |
| 130 | blobIDs.begin(), blobIDs.end(), |
| 131 | [toDelete](const auto& iter) { return (iter == *toDelete); }); |
| 132 | if (it == blobIDs.end()) |
| 133 | { |
| 134 | /* Somehow they've asked to delete something we didn't say we could |
| 135 | * handle. |
| 136 | */ |
| 137 | return false; |
| 138 | } |
| 139 | |
| 140 | blobIDs.erase(it); |
| 141 | |
| 142 | /* TODO: Handle aborting the process and fixing up the state. */ |
| 143 | |
| 144 | return true; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 145 | } |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 146 | |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 147 | /* |
| 148 | * Stat on the files will return information such as what supported |
| 149 | * transport mechanisms are available. |
| 150 | * |
| 151 | * Stat on an active file or hash will return information such as the size |
| 152 | * of the data cached, and any additional pertinent information. The |
| 153 | * blob_state on the active files will return the state of the update. |
| 154 | */ |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 155 | bool FirmwareBlobHandler::stat(const std::string& path, |
| 156 | struct blobs::BlobMeta* meta) |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 157 | { |
Patrick Venture | 46637c8 | 2018-11-06 15:20:24 -0800 | [diff] [blame] | 158 | /* We know we support this path because canHandle is called ahead */ |
Patrick Venture | d342a95 | 2019-05-29 09:09:10 -0700 | [diff] [blame] | 159 | if (path == verifyBlobId || path == activeImageBlobId || |
Patrick Venture | 5f56269 | 2019-05-30 16:49:46 -0700 | [diff] [blame] | 160 | path == activeHashBlobId || path == updateBlobId) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 161 | { |
Patrick Venture | d342a95 | 2019-05-29 09:09:10 -0700 | [diff] [blame] | 162 | /* These blobs are placeholders that indicate things, or allow actions, |
| 163 | * but are not stat-able as-is. |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 164 | */ |
Patrick Venture | d342a95 | 2019-05-29 09:09:10 -0700 | [diff] [blame] | 165 | return false; |
Patrick Venture | 46637c8 | 2018-11-06 15:20:24 -0800 | [diff] [blame] | 166 | } |
| 167 | |
Patrick Venture | d342a95 | 2019-05-29 09:09:10 -0700 | [diff] [blame] | 168 | /* They are requesting information about the generic blob_id. */ |
| 169 | meta->blobState = bitmask; |
| 170 | meta->size = 0; |
| 171 | |
| 172 | /* The generic blob_ids state is only the bits related to the transport |
| 173 | * mechanisms. |
| 174 | */ |
| 175 | return true; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 176 | } |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 177 | |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 178 | /* |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 179 | * Return stat information on an open session. It therefore must be an active |
| 180 | * handle to either the active image or active hash. |
| 181 | * |
| 182 | * The stat() and sessionstat() commands will return the same information in |
| 183 | * many cases, therefore the logic will be combined. |
| 184 | * |
| 185 | * TODO: combine the logic for stat and sessionstat(). |
| 186 | */ |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 187 | bool FirmwareBlobHandler::stat(uint16_t session, struct blobs::BlobMeta* meta) |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 188 | { |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 189 | auto item = lookup.find(session); |
| 190 | if (item == lookup.end()) |
| 191 | { |
| 192 | return false; |
| 193 | } |
| 194 | |
Patrick Venture | b3b4db7 | 2019-05-15 11:30:24 -0700 | [diff] [blame] | 195 | /* The size here refers to the size of the file -- of something analagous. |
| 196 | */ |
| 197 | meta->size = (item->second->imageHandler) |
| 198 | ? item->second->imageHandler->getSize() |
| 199 | : 0; |
| 200 | |
| 201 | meta->metadata.clear(); |
| 202 | |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 203 | if (item->second->activePath == verifyBlobId) |
Patrick Venture | b3b4db7 | 2019-05-15 11:30:24 -0700 | [diff] [blame] | 204 | { |
Patrick Venture | 01a3327 | 2019-05-23 19:48:22 -0700 | [diff] [blame] | 205 | VerifyCheckResponses value; |
| 206 | |
Patrick Venture | 40d7ffc | 2019-05-30 17:12:06 -0700 | [diff] [blame^] | 207 | switch (state) |
Patrick Venture | 01a3327 | 2019-05-23 19:48:22 -0700 | [diff] [blame] | 208 | { |
Patrick Venture | 40d7ffc | 2019-05-30 17:12:06 -0700 | [diff] [blame^] | 209 | case UpdateState::verificationPending: |
| 210 | value = VerifyCheckResponses::other; |
| 211 | break; |
| 212 | case UpdateState::verificationCompleted: |
| 213 | value = lastVerificationResponse; |
| 214 | break; |
| 215 | default: |
| 216 | value = verification->checkVerificationState(); |
| 217 | lastVerificationResponse = value; |
Patrick Venture | 01a3327 | 2019-05-23 19:48:22 -0700 | [diff] [blame] | 218 | } |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 219 | |
Patrick Venture | e955e07 | 2019-05-15 16:16:46 -0700 | [diff] [blame] | 220 | meta->metadata.push_back(static_cast<std::uint8_t>(value)); |
| 221 | |
| 222 | /* Change the firmware handler's state and the blob's stat value |
| 223 | * depending. |
| 224 | */ |
| 225 | if (value == VerifyCheckResponses::success || |
| 226 | value == VerifyCheckResponses::failed) |
| 227 | { |
| 228 | state = UpdateState::verificationCompleted; |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 229 | item->second->flags &= ~blobs::StateFlags::committing; |
Patrick Venture | e955e07 | 2019-05-15 16:16:46 -0700 | [diff] [blame] | 230 | |
| 231 | if (value == VerifyCheckResponses::success) |
| 232 | { |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 233 | item->second->flags |= blobs::StateFlags::committed; |
Patrick Venture | e955e07 | 2019-05-15 16:16:46 -0700 | [diff] [blame] | 234 | } |
| 235 | else |
| 236 | { |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 237 | item->second->flags |= blobs::StateFlags::commit_error; |
Patrick Venture | e955e07 | 2019-05-15 16:16:46 -0700 | [diff] [blame] | 238 | } |
| 239 | } |
Patrick Venture | b3b4db7 | 2019-05-15 11:30:24 -0700 | [diff] [blame] | 240 | } |
Patrick Venture | 40d7ffc | 2019-05-30 17:12:06 -0700 | [diff] [blame^] | 241 | else if (item->second->activePath == updateBlobId) |
| 242 | { |
| 243 | UpdateStatus value; |
| 244 | |
| 245 | switch (state) |
| 246 | { |
| 247 | case UpdateState::updatePending: |
| 248 | value = UpdateStatus::unknown; |
| 249 | break; |
| 250 | default: |
| 251 | break; |
| 252 | } |
| 253 | |
| 254 | meta->metadata.push_back(static_cast<std::uint8_t>(value)); |
| 255 | } |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 256 | |
Patrick Venture | e955e07 | 2019-05-15 16:16:46 -0700 | [diff] [blame] | 257 | /* The blobState here relates to an active sesion, so we should return the |
| 258 | * flags used to open this session. |
| 259 | */ |
| 260 | meta->blobState = item->second->flags; |
| 261 | |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 262 | /* The metadata blob returned comes from the data handler... it's used for |
| 263 | * instance, in P2A bridging to get required information about the mapping, |
| 264 | * and is the "opposite" of the lpc writemeta requirement. |
| 265 | */ |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 266 | if (item->second->dataHandler) |
| 267 | { |
Patrick Venture | 7430464 | 2019-01-17 09:31:04 -0800 | [diff] [blame] | 268 | auto bytes = item->second->dataHandler->readMeta(); |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 269 | meta->metadata.insert(meta->metadata.begin(), bytes.begin(), |
| 270 | bytes.end()); |
| 271 | } |
| 272 | |
Patrick Venture | cc7d160 | 2018-11-15 13:58:33 -0800 | [diff] [blame] | 273 | return true; |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 274 | } |
| 275 | |
| 276 | /* |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 277 | * If you open /flash/image or /flash/tarball, or /flash/hash it will |
| 278 | * interpret the open flags and perform whatever actions are required for |
| 279 | * that update process. The session returned can be used immediately for |
| 280 | * sending data down, without requiring one to open the new active file. |
| 281 | * |
| 282 | * If you open the active flash image or active hash it will let you |
| 283 | * overwrite pieces, depending on the state. |
| 284 | * |
| 285 | * Once the verification process has started the active files cannot be |
| 286 | * opened. |
| 287 | * |
| 288 | * You can only have one open session at a time. Which means, you can only |
| 289 | * have one file open at a time. Trying to open the hash blob_id while you |
| 290 | * still have the flash image blob_id open will fail. Opening the flash |
| 291 | * blob_id when it is already open will fail. |
| 292 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 293 | bool FirmwareBlobHandler::open(uint16_t session, uint16_t flags, |
| 294 | const std::string& path) |
| 295 | { |
Patrick Venture | 6e307a7 | 2018-11-09 18:21:17 -0800 | [diff] [blame] | 296 | /* Check that they've opened for writing - read back not currently |
| 297 | * supported. |
| 298 | */ |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 299 | if ((flags & blobs::OpenFlags::write) == 0) |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 300 | { |
| 301 | return false; |
| 302 | } |
| 303 | |
Patrick Venture | b1b68fc | 2018-11-09 09:37:04 -0800 | [diff] [blame] | 304 | /* Is the verification process underway? */ |
| 305 | if (state == UpdateState::verificationStarted) |
| 306 | { |
| 307 | return false; |
| 308 | } |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 309 | |
| 310 | /* Is there an open session already? We only allow one at a time. |
Patrick Venture | 6e307a7 | 2018-11-09 18:21:17 -0800 | [diff] [blame] | 311 | * |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 312 | * TODO: Temporarily using a simple boolean flag until there's a full |
| 313 | * session object to check. |
Patrick Venture | 7c8b97e | 2018-11-08 09:14:30 -0800 | [diff] [blame] | 314 | * |
| 315 | * Further on this, if there's an active session to the hash we don't allow |
| 316 | * re-opening the image, and if we have the image open, we don't allow |
| 317 | * opening the hash. This design decision may be re-evaluated, and changed |
| 318 | * to only allow one session per object type (of the two types). But, |
| 319 | * consider if the hash is open, do we want to allow writing to the image? |
| 320 | * And why would we? But, really, the point of no-return is once the |
| 321 | * verification process has begun -- which is done via commit() on the hash |
| 322 | * blob_id, we no longer want to allow updating the contents. |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 323 | */ |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 324 | if (fileOpen) |
| 325 | { |
| 326 | return false; |
| 327 | } |
| 328 | |
Patrick Venture | 19f5d88 | 2019-05-30 14:34:55 -0700 | [diff] [blame] | 329 | /* When in this state, they can only open the updateBlobId */ |
| 330 | if (state == UpdateState::updatePending) |
| 331 | { |
| 332 | if (path != updateBlobId) |
| 333 | { |
| 334 | return false; |
| 335 | } |
| 336 | else |
| 337 | { |
| 338 | /* Similarly to verifyBlodId, this is special. */ |
| 339 | updateImage.flags = flags; |
| 340 | updateImage.state = Session::State::open; |
| 341 | |
| 342 | lookup[session] = &updateImage; |
| 343 | |
| 344 | fileOpen = true; |
| 345 | return true; |
| 346 | } |
| 347 | } |
| 348 | |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 349 | /* Handle opening the verifyBlobId --> we know the image and hash aren't |
| 350 | * open because of the fileOpen check. |
| 351 | * |
| 352 | * The file must be opened for writing, but no transport mechanism specified |
| 353 | * since it's irrelevant. |
| 354 | */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 355 | if (path == verifyBlobId) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 356 | { |
| 357 | /* In this case, there's no image handler to use, or data handler, |
| 358 | * simply set up a session. |
| 359 | */ |
| 360 | verifyImage.flags = flags; |
| 361 | verifyImage.state = Session::State::open; |
| 362 | |
| 363 | lookup[session] = &verifyImage; |
| 364 | |
| 365 | fileOpen = true; |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 366 | return true; |
| 367 | } |
| 368 | |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 369 | /* There are two abstractions at play, how you get the data and how you |
| 370 | * handle that data. such that, whether the data comes from the PCI bridge |
| 371 | * or LPC bridge is not connected to whether the data goes into a static |
| 372 | * layout flash update or a UBI tarball. |
| 373 | */ |
| 374 | |
Patrick Venture | 19f5d88 | 2019-05-30 14:34:55 -0700 | [diff] [blame] | 375 | /* 2) there isn't, so what are they opening? */ |
| 376 | if (path == activeImageBlobId || path == activeHashBlobId) |
| 377 | { |
| 378 | /* 2a) are they opening the active image? this can only happen if they |
| 379 | * already started one (due to canHandleBlob's behavior). |
| 380 | */ |
| 381 | /* 2b) are they opening the active hash? this can only happen if they |
| 382 | * already started one (due to canHandleBlob's behavior). |
| 383 | */ |
| 384 | return false; |
| 385 | } |
| 386 | |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 387 | /* Check the flags for the transport mechanism: if none match we don't |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 388 | * support what they request. |
| 389 | */ |
Patrick Venture | 1cde5f9 | 2018-11-07 08:26:47 -0800 | [diff] [blame] | 390 | if ((flags & bitmask) == 0) |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 391 | { |
| 392 | return false; |
| 393 | } |
| 394 | |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 395 | /* How are they expecting to copy this data? */ |
| 396 | auto d = std::find_if( |
| 397 | transports.begin(), transports.end(), |
| 398 | [&flags](const auto& iter) { return (iter.bitmask & flags); }); |
| 399 | if (d == transports.end()) |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 400 | { |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 401 | return false; |
| 402 | } |
| 403 | |
| 404 | /* We found the transport handler they requested, no surprise since |
| 405 | * above we verify they selected at least one we wanted. |
| 406 | */ |
Patrick Venture | c02849b | 2018-11-06 17:31:15 -0800 | [diff] [blame] | 407 | |
Patrick Venture | 6e307a7 | 2018-11-09 18:21:17 -0800 | [diff] [blame] | 408 | /* Elsewhere I do this check by checking "if ::ipmi" because that's the |
| 409 | * only non-external data pathway -- but this is just a more generic |
| 410 | * approach to that. |
| 411 | */ |
| 412 | if (d->handler) |
| 413 | { |
| 414 | /* If the data handler open call fails, open fails. */ |
| 415 | if (!d->handler->open()) |
| 416 | { |
| 417 | return false; |
| 418 | } |
| 419 | } |
| 420 | |
Patrick Venture | 70e30bf | 2019-01-17 10:29:28 -0800 | [diff] [blame] | 421 | /* Do we have a file handler for the type of file they're opening. |
| 422 | * Note: This should only fail if something is somehow crazy wrong. |
| 423 | * Since the canHandle() said yes, and that's tied into the list of explicit |
| 424 | * firmware handers (and file handlers, like this'll know where to write the |
| 425 | * tarball, etc). |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 426 | */ |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 427 | auto h = std::find_if( |
| 428 | handlers.begin(), handlers.end(), |
| 429 | [&path](const auto& iter) { return (iter.blobName == path); }); |
| 430 | if (h == handlers.end()) |
| 431 | { |
| 432 | return false; |
| 433 | } |
| 434 | |
| 435 | /* Ok, so we found a handler that matched, so call open() */ |
| 436 | if (!h->handler->open(path)) |
| 437 | { |
| 438 | return false; |
| 439 | } |
| 440 | |
Patrick Venture | 70e30bf | 2019-01-17 10:29:28 -0800 | [diff] [blame] | 441 | Session* curr; |
| 442 | const std::string* active; |
| 443 | |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 444 | if (path == hashBlobId) |
Patrick Venture | 70e30bf | 2019-01-17 10:29:28 -0800 | [diff] [blame] | 445 | { |
| 446 | /* 2c) are they opening the /flash/hash ? (to start the process) */ |
| 447 | curr = &activeHash; |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 448 | active = &activeHashBlobId; |
Patrick Venture | 70e30bf | 2019-01-17 10:29:28 -0800 | [diff] [blame] | 449 | } |
| 450 | else |
| 451 | { |
| 452 | curr = &activeImage; |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 453 | active = &activeImageBlobId; |
Patrick Venture | 70e30bf | 2019-01-17 10:29:28 -0800 | [diff] [blame] | 454 | } |
| 455 | |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 456 | curr->flags = flags; |
| 457 | curr->dataHandler = d->handler; |
| 458 | curr->imageHandler = h->handler; |
Patrick Venture | cd31022 | 2018-11-09 18:47:13 -0800 | [diff] [blame] | 459 | curr->state = Session::State::open; |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 460 | |
| 461 | lookup[session] = curr; |
| 462 | |
Patrick Venture | efba42d | 2019-05-24 10:48:16 -0700 | [diff] [blame] | 463 | addBlobId(*active); |
Patrick Venture | 930c7b7 | 2019-05-24 11:11:08 -0700 | [diff] [blame] | 464 | removeBlobId(verifyBlobId); |
Patrick Venture | db253bf | 2018-11-09 19:36:03 -0800 | [diff] [blame] | 465 | |
Patrick Venture | 12233c5 | 2019-05-16 09:26:59 -0700 | [diff] [blame] | 466 | state = UpdateState::uploadInProgress; |
Patrick Venture | 991910a | 2018-11-09 19:43:48 -0800 | [diff] [blame] | 467 | fileOpen = true; |
| 468 | |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 469 | return true; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 470 | } |
Patrick Venture | 5397796 | 2018-11-02 18:59:35 -0700 | [diff] [blame] | 471 | |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 472 | /** |
| 473 | * The write command really just grabs the data from wherever it is and sends it |
| 474 | * to the image handler. It's the image handler's responsibility to deal with |
| 475 | * the data provided. |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 476 | * |
| 477 | * This receives a session from the blob manager, therefore it is always called |
| 478 | * between open() and close(). |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 479 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 480 | bool FirmwareBlobHandler::write(uint16_t session, uint32_t offset, |
| 481 | const std::vector<uint8_t>& data) |
| 482 | { |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 483 | auto item = lookup.find(session); |
| 484 | if (item == lookup.end()) |
| 485 | { |
| 486 | return false; |
| 487 | } |
| 488 | |
Patrick Venture | b1b68fc | 2018-11-09 09:37:04 -0800 | [diff] [blame] | 489 | /* Prevent writing during verification. */ |
| 490 | if (state == UpdateState::verificationStarted) |
| 491 | { |
| 492 | return false; |
| 493 | } |
| 494 | |
Patrick Venture | 4e2fdcd | 2019-05-30 14:58:57 -0700 | [diff] [blame] | 495 | /* Prevent writing to the verification or update blobs. */ |
| 496 | if (item->second->activePath == verifyBlobId || |
| 497 | item->second->activePath == updateBlobId) |
Patrick Venture | 8af15eb | 2019-05-15 09:39:22 -0700 | [diff] [blame] | 498 | { |
| 499 | return false; |
| 500 | } |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 501 | |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 502 | std::vector<std::uint8_t> bytes; |
| 503 | |
Patrick Venture | 05abf7e | 2018-11-09 11:02:56 -0800 | [diff] [blame] | 504 | if (item->second->flags & UpdateFlags::ipmi) |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 505 | { |
| 506 | bytes = data; |
| 507 | } |
| 508 | else |
| 509 | { |
| 510 | /* little endian required per design, and so on, but TODO: do endianness |
| 511 | * with boost. |
| 512 | */ |
| 513 | struct ExtChunkHdr header; |
| 514 | |
| 515 | if (data.size() != sizeof(header)) |
| 516 | { |
| 517 | return false; |
| 518 | } |
| 519 | |
| 520 | std::memcpy(&header, data.data(), data.size()); |
| 521 | bytes = item->second->dataHandler->copyFrom(header.length); |
| 522 | } |
| 523 | |
| 524 | return item->second->imageHandler->write(offset, bytes); |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 525 | } |
Patrick Venture | 18235e6 | 2018-11-08 10:21:09 -0800 | [diff] [blame] | 526 | |
Patrick Venture | 8c53533 | 2018-11-08 15:58:00 -0800 | [diff] [blame] | 527 | /* |
| 528 | * If the active session (image or hash) is over LPC, this allows |
| 529 | * configuring it. This option is only available before you start |
| 530 | * writing data for the given item (image or hash). This will return |
| 531 | * false at any other part. -- the lpc handler portion will know to return |
| 532 | * false. |
| 533 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 534 | bool FirmwareBlobHandler::writeMeta(uint16_t session, uint32_t offset, |
| 535 | const std::vector<uint8_t>& data) |
| 536 | { |
Patrick Venture | 8c53533 | 2018-11-08 15:58:00 -0800 | [diff] [blame] | 537 | auto item = lookup.find(session); |
| 538 | if (item == lookup.end()) |
| 539 | { |
| 540 | return false; |
| 541 | } |
| 542 | |
Patrick Venture | 05abf7e | 2018-11-09 11:02:56 -0800 | [diff] [blame] | 543 | if (item->second->flags & UpdateFlags::ipmi) |
Patrick Venture | 8c53533 | 2018-11-08 15:58:00 -0800 | [diff] [blame] | 544 | { |
| 545 | return false; |
| 546 | } |
| 547 | |
Patrick Venture | d56097a | 2019-05-15 09:47:55 -0700 | [diff] [blame] | 548 | /* Prevent writing meta to the verification blob (it has no data handler). |
| 549 | */ |
| 550 | if (item->second->dataHandler) |
| 551 | { |
| 552 | return item->second->dataHandler->writeMeta(data); |
| 553 | } |
Patrick Venture | 699750d | 2019-05-15 09:24:09 -0700 | [diff] [blame] | 554 | |
Patrick Venture | d56097a | 2019-05-15 09:47:55 -0700 | [diff] [blame] | 555 | return false; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 556 | } |
Patrick Venture | 8c53533 | 2018-11-08 15:58:00 -0800 | [diff] [blame] | 557 | |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 558 | /* |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 559 | * If this command is called on the session for the verifyBlobId, it'll |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 560 | * trigger a systemd service `verify_image.service` to attempt to verify |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 561 | * the image. |
| 562 | * |
| 563 | * For this file to have opened, the other two must be closed, which means any |
| 564 | * out-of-band transport mechanism involved is closed. |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 565 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 566 | bool FirmwareBlobHandler::commit(uint16_t session, |
| 567 | const std::vector<uint8_t>& data) |
| 568 | { |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 569 | auto item = lookup.find(session); |
| 570 | if (item == lookup.end()) |
| 571 | { |
| 572 | return false; |
| 573 | } |
| 574 | |
| 575 | /* You can only commit on the verifyBlodId */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 576 | if (item->second->activePath != verifyBlobId) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 577 | { |
| 578 | return false; |
| 579 | } |
| 580 | |
Patrick Venture | 433cbc3 | 2019-05-30 09:53:10 -0700 | [diff] [blame] | 581 | switch (state) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 582 | { |
Patrick Venture | 433cbc3 | 2019-05-30 09:53:10 -0700 | [diff] [blame] | 583 | case UpdateState::verificationStarted: |
| 584 | /* Calling repeatedly has no effect within an update process. */ |
| 585 | return true; |
| 586 | case UpdateState::verificationCompleted: |
| 587 | /* Calling after the verification process has completed returns |
| 588 | * failure. */ |
| 589 | return false; |
| 590 | default: |
| 591 | /* Set state to committing. */ |
| 592 | item->second->flags |= blobs::StateFlags::committing; |
| 593 | return triggerVerification(); |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 594 | } |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 595 | } |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 596 | |
| 597 | /* |
| 598 | * Close must be called on the firmware image before triggering |
| 599 | * verification via commit. Once the verification is complete, you can |
| 600 | * then close the hash file. |
| 601 | * |
| 602 | * If the `verify_image.service` returned success, closing the hash file |
| 603 | * will have a specific behavior depending on the update. If it's UBI, |
| 604 | * it'll perform the install. If it's static layout, it'll do nothing. The |
| 605 | * verify_image service in the static layout case is responsible for placing |
| 606 | * the file in the correct staging position. |
| 607 | */ |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 608 | bool FirmwareBlobHandler::close(uint16_t session) |
| 609 | { |
Patrick Venture | 68bb143 | 2018-11-09 20:08:48 -0800 | [diff] [blame] | 610 | auto item = lookup.find(session); |
| 611 | if (item == lookup.end()) |
| 612 | { |
| 613 | return false; |
| 614 | } |
| 615 | |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 616 | /* Are you closing the verify blob? */ |
Patrick Venture | 7dad86f | 2019-05-17 08:52:20 -0700 | [diff] [blame] | 617 | if (item->second->activePath == verifyBlobId) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 618 | { |
Patrick Venture | 1c6d8f5 | 2019-05-30 10:53:49 -0700 | [diff] [blame] | 619 | switch (state) |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 620 | { |
Patrick Venture | 1c6d8f5 | 2019-05-30 10:53:49 -0700 | [diff] [blame] | 621 | case UpdateState::verificationStarted: |
| 622 | /* TODO: If they close this blob before verification finishes, |
| 623 | * that's an abort. |
| 624 | */ |
| 625 | return false; |
| 626 | case UpdateState::verificationCompleted: |
| 627 | if (lastVerificationResponse == VerifyCheckResponses::success) |
| 628 | { |
| 629 | state = UpdateState::updatePending; |
| 630 | addBlobId(updateBlobId); |
Patrick Venture | ad93383 | 2019-05-30 14:13:29 -0700 | [diff] [blame] | 631 | removeBlobId(verifyBlobId); |
Patrick Venture | 1c6d8f5 | 2019-05-30 10:53:49 -0700 | [diff] [blame] | 632 | } |
| 633 | else |
| 634 | { |
| 635 | /* TODO: Verification failed, what now? */ |
| 636 | state = UpdateState::notYetStarted; |
| 637 | } |
Patrick Venture | 40d7ffc | 2019-05-30 17:12:06 -0700 | [diff] [blame^] | 638 | break; |
Patrick Venture | 1c6d8f5 | 2019-05-30 10:53:49 -0700 | [diff] [blame] | 639 | default: |
Patrick Venture | 40d7ffc | 2019-05-30 17:12:06 -0700 | [diff] [blame^] | 640 | break; |
Patrick Venture | 12233c5 | 2019-05-16 09:26:59 -0700 | [diff] [blame] | 641 | } |
| 642 | /* Must be verificationPending... not yet started, they may re-open and |
| 643 | * trigger verification. |
| 644 | */ |
| 645 | } |
Patrick Venture | 6b0aa18 | 2019-05-30 14:47:32 -0700 | [diff] [blame] | 646 | else if (item->second->activePath == updateBlobId) |
| 647 | { |
| 648 | /* nothing interesting. */ |
| 649 | } |
Patrick Venture | 12233c5 | 2019-05-16 09:26:59 -0700 | [diff] [blame] | 650 | else |
| 651 | { |
| 652 | /* They are closing a data pathway (image, tarball, hash). */ |
| 653 | state = UpdateState::verificationPending; |
Patrick Venture | 930c7b7 | 2019-05-24 11:11:08 -0700 | [diff] [blame] | 654 | |
| 655 | /* Add verify blob ID now that we can expect it. */ |
| 656 | addBlobId(verifyBlobId); |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 657 | } |
| 658 | |
Patrick Venture | 68bb143 | 2018-11-09 20:08:48 -0800 | [diff] [blame] | 659 | if (item->second->dataHandler) |
| 660 | { |
| 661 | item->second->dataHandler->close(); |
| 662 | } |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 663 | if (item->second->imageHandler) |
| 664 | { |
| 665 | item->second->imageHandler->close(); |
| 666 | } |
| 667 | |
Patrick Venture | 68bb143 | 2018-11-09 20:08:48 -0800 | [diff] [blame] | 668 | item->second->state = Session::State::closed; |
Patrick Venture | 68bb143 | 2018-11-09 20:08:48 -0800 | [diff] [blame] | 669 | lookup.erase(item); |
Patrick Venture | 991910a | 2018-11-09 19:43:48 -0800 | [diff] [blame] | 670 | fileOpen = false; |
Patrick Venture | 68bb143 | 2018-11-09 20:08:48 -0800 | [diff] [blame] | 671 | return true; |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 672 | } |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 673 | |
Patrick Venture | c7ca291 | 2018-11-02 11:38:33 -0700 | [diff] [blame] | 674 | bool FirmwareBlobHandler::expire(uint16_t session) |
| 675 | { |
| 676 | return false; |
| 677 | } |
Patrick Venture | d6461d6 | 2018-11-09 17:30:25 -0800 | [diff] [blame] | 678 | |
| 679 | /* |
| 680 | * Currently, the design does not provide this with a function, however, |
| 681 | * it will likely change to support reading data back. |
| 682 | */ |
| 683 | std::vector<uint8_t> FirmwareBlobHandler::read(uint16_t session, |
| 684 | uint32_t offset, |
| 685 | uint32_t requestedSize) |
| 686 | { |
| 687 | return {}; |
| 688 | } |
| 689 | |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 690 | bool FirmwareBlobHandler::triggerVerification() |
| 691 | { |
Patrick Venture | 3ecb350 | 2019-05-17 11:03:51 -0700 | [diff] [blame] | 692 | bool result = verification->triggerVerification(); |
| 693 | if (result) |
Patrick Venture | cabc117 | 2018-11-16 16:14:26 -0800 | [diff] [blame] | 694 | { |
Patrick Venture | 453f06a | 2019-01-17 10:02:12 -0800 | [diff] [blame] | 695 | state = UpdateState::verificationStarted; |
Patrick Venture | cabc117 | 2018-11-16 16:14:26 -0800 | [diff] [blame] | 696 | } |
Patrick Venture | cabc117 | 2018-11-16 16:14:26 -0800 | [diff] [blame] | 697 | |
Patrick Venture | 3ecb350 | 2019-05-17 11:03:51 -0700 | [diff] [blame] | 698 | return result; |
Patrick Venture | ffcc550 | 2018-11-16 12:32:38 -0800 | [diff] [blame] | 699 | } |
| 700 | |
Patrick Venture | 1d5a31c | 2019-05-20 11:38:22 -0700 | [diff] [blame] | 701 | } // namespace ipmi_flash |