commit 405ea28684703dfc609ad8a42c853a5a609fa61c
author George Liu <liuxiwei@ieisystem.com> Thu Aug 22 19:36:41 2024 +0800
committer George Liu <liuxiwei@ieisystem.com> Wed Aug 28 08:34:27 2024 +0800
tree e664f775f47f7c1c1fffcb2bbd92f149dbbfdc1c
parent effb343e253db39d9c75c81ceb81044fb7d06397

clang-tidy: Enable readability-const-return-type check

Checks for functions with a const-qualified return type and
recommends removal of the const keyword. Such use of const is usually
superfluous, and can prevent valuable compiler optimizations. Does
not (yet) fix trailing return types.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ifff7541c95d7881d8c6407b20c906ec7eb13abf1

manager/json-parser.hpp

diff --git a/manager/json-parser.hpp b/manager/json-parser.hpp
index 0846a03..d7043be 100644
--- a/manager/json-parser.hpp
+++ b/manager/json-parser.hpp
@@ -133,7 +133,7 @@
  *
  *  @return phosphor::led::GroupMap
  */
-const phosphor::led::GroupMap loadJsonConfigV1(const Json& json)
+phosphor::led::GroupMap loadJsonConfigV1(const Json& json)
 {
     phosphor::led::GroupMap ledMap{};
 
@@ -153,7 +153,7 @@
  *
  *  @return phosphor::led::GroupMap
  */
-const phosphor::led::GroupMap loadJsonConfig(const fs::path& path)
+phosphor::led::GroupMap loadJsonConfig(const fs::path& path)
 {
     auto json = readJson(path);
 
@@ -180,7 +180,7 @@
  *  @note if config is an empty string, daemon will interrogate dbus for
  *        compatible strings.
  */
-const phosphor::led::GroupMap getSystemLedMap(fs::path config)
+phosphor::led::GroupMap getSystemLedMap(fs::path config)
 {
     if (config.empty())
     {