commit 405ea28684703dfc609ad8a42c853a5a609fa61c
author George Liu <liuxiwei@ieisystem.com> Thu Aug 22 19:36:41 2024 +0800
committer George Liu <liuxiwei@ieisystem.com> Wed Aug 28 08:34:27 2024 +0800
tree e664f775f47f7c1c1fffcb2bbd92f149dbbfdc1c
parent effb343e253db39d9c75c81ceb81044fb7d06397

clang-tidy: Enable readability-const-return-type check

Checks for functions with a const-qualified return type and
recommends removal of the const keyword. Such use of const is usually
superfluous, and can prevent valuable compiler optimizations. Does
not (yet) fix trailing return types.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ifff7541c95d7881d8c6407b20c906ec7eb13abf1

utils.hpp

diff --git a/utils.hpp b/utils.hpp
index eb28e07..cd79fd5 100644
--- a/utils.hpp
+++ b/utils.hpp
@@ -52,8 +52,8 @@
      *  @return std::string  -  the D-Bus service name
      *
      */
-    const std::string getService(const std::string& path,
-                                 const std::string& interface) const;
+    std::string getService(const std::string& path,
+                           const std::string& interface) const;
 
     /** @brief Get All properties
      *
@@ -64,8 +64,8 @@
      *
      *  @throw sdbusplus::exception_t when it fails
      */
-    const PropertyMap getAllProperties(const std::string& objectPath,
-                                       const std::string& interface) const;
+    PropertyMap getAllProperties(const std::string& objectPath,
+                                 const std::string& interface) const;
 
     /** @brief Get property(type: variant)
      *
@@ -77,9 +77,9 @@
      *
      *  @throw sdbusplus::exception_t when it fails
      */
-    const PropertyValue getProperty(const std::string& objectPath,
-                                    const std::string& interface,
-                                    const std::string& propertyName) const;
+    PropertyValue getProperty(const std::string& objectPath,
+                              const std::string& interface,
+                              const std::string& propertyName) const;
 
     /** @brief Set D-Bus property
      *
@@ -102,8 +102,8 @@
      *
      *  @return std::vector<std::string> vector of subtree paths
      */
-    const std::vector<std::string> getSubTreePaths(
-        const std::string& objectPath, const std::string& interface);
+    std::vector<std::string> getSubTreePaths(
+        const std::string& objectPath, const std::string& interface) const;
 };
 
 } // namespace utils