commit 49875a26a8a8510ee281bbf0e6828b618b66c4eb
author George Liu <liuxiwei@ieisystem.com> Fri Aug 23 08:58:59 2024 +0800
committer George Liu <liuxiwei@ieisystem.com> Wed Aug 28 09:41:50 2024 +0800
tree fffa35d2459cfe5e6b51ead9f5678e79d87f6127
parent 80f51bbb5ce8468515fd082bcff1dd570416a42e

clang-tidy: Enable readability-implicit-bool-conversion check

This check can be used to find implicit conversions between
built-in types and booleans.
the following conversion types are checked:
- integer expression/literal to boolean
- floating expression/literal to boolean
- pointer/pointer to member/nullptr/NULL to boolean
- boolean expression/literal to integer
- boolean expression/literal to floating

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3f4bc8902e255d1c85ec57f47d9532ee7326a442

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index 775d2d3..17375d0 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -260,6 +260,7 @@
 readability-deleted-default,
 readability-function-size,
 readability-identifier-naming,
+readability-implicit-bool-conversion,
 readability-isolate-declaration,
 readability-make-member-function-const,
 readability-misleading-indentation,

manager/lamptest/lamptest.cpp

diff --git a/manager/lamptest/lamptest.cpp b/manager/lamptest/lamptest.cpp
index f91a085..f7f9e90 100644
--- a/manager/lamptest/lamptest.cpp
+++ b/manager/lamptest/lamptest.cpp
@@ -246,7 +246,7 @@
 void LampTest::timeOutHandler()
 {
     // set the Asserted property of lamp test to false
-    if (!groupObj)
+    if (groupObj == nullptr)
     {
         lg2::error("the Group object is nullptr");
         throw std::runtime_error("the Group object is nullptr");

manager/manager.cpp

diff --git a/manager/manager.cpp b/manager/manager.cpp
index 3dfa92a..df65426 100644
--- a/manager/manager.cpp
+++ b/manager/manager.cpp
@@ -273,7 +273,7 @@
         lg2::debug("De-Asserting LED, NAME = {NAME}, ACTION = {ACTION}", "NAME",
                    it.name, "ACTION", it.action);
         if (drivePhysicalLED(objPath, Layout::Action::Off, it.dutyOn,
-                             it.period))
+                             it.period) != 0)
         {
             failedLedsDeAssert.insert(it);
         }
@@ -284,7 +284,7 @@
         std::string objPath = std::string(phyLedPath) + it.name;
         lg2::debug("Asserting LED, NAME = {NAME}, ACTION = {ACTION}", "NAME",
                    it.name, "ACTION", it.action);
-        if (drivePhysicalLED(objPath, it.action, it.dutyOn, it.period))
+        if (drivePhysicalLED(objPath, it.action, it.dutyOn, it.period) != 0)
         {
             failedLedsAssert.insert(it);
         }