clang-tidy: Enable readability-avoid-const-params-in-decls check
Checks whether a function declaration has parameters that are top
level const.
const values in declarations do not affect the signature of a
function, so they should not be put there.
Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ic4c2fc0f4ce0ce03fd6621d1f8c928890cf5da88
diff --git a/.clang-tidy b/.clang-tidy
index ef9193b..775d2d3 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -253,6 +253,7 @@
performance-trivially-destructible,
performance-type-promotion-in-math-fn,
performance-unnecessary-copy-initialization,
+readability-avoid-const-params-in-decls,
readability-const-return-type,
readability-convert-member-functions-to-static,
readability-delete-null-pointer,
diff --git a/manager/manager.cpp b/manager/manager.cpp
index 7c7d730..3dfa92a 100644
--- a/manager/manager.cpp
+++ b/manager/manager.cpp
@@ -208,7 +208,7 @@
// Calls into driving physical LED post choosing the action
int Manager::drivePhysicalLED(const std::string& objPath, Layout::Action action,
- uint8_t dutyOn, const uint16_t period)
+ uint8_t dutyOn, uint16_t period)
{
try
{
diff --git a/manager/manager.hpp b/manager/manager.hpp
index 053a6a7..045586f 100644
--- a/manager/manager.hpp
+++ b/manager/manager.hpp
@@ -132,7 +132,7 @@
*/
static int drivePhysicalLED(const std::string& objPath,
Layout::Action action, uint8_t dutyOn,
- const uint16_t period);
+ uint16_t period);
/** @brief Set lamp test callback when enabled lamp test.
*