commit c5e0f31c4e6c69a1d50168dfdcc3537cdaf56fc6
author George Liu <liuxiwei@inspur.com> Mon Dec 27 15:54:31 2021 +0800
committer George Liu <liuxiwei@inspur.com> Wed Dec 29 10:12:13 2021 +0800
tree defaf227d3a8268b5c3e0fc79a3560921214756a
parent db6d763891a8526197478c24616b8740f92742d5

Fix some warnings by cppcheck

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Icee0abe2e3130aa225db776efdcd47200eb38f8d

lamptest.cpp

diff --git a/lamptest.cpp b/lamptest.cpp
index 4c58e80..cd87bc2 100644
--- a/lamptest.cpp
+++ b/lamptest.cpp
@@ -2,6 +2,8 @@
 
 #include <phosphor-logging/lg2.hpp>
 
+#include <algorithm>
+
 namespace phosphor
 {
 namespace led
@@ -276,16 +278,12 @@
         // define the default JSON as empty
         const std::vector<std::string> empty{};
         auto forceLEDs = json.value("forceLEDs", empty);
-        for (auto& member : forceLEDs)
-        {
-            forceUpdateLEDs.push_back(PHY_LED_PATH + member);
-        }
+        std::ranges::transform(forceLEDs, std::back_inserter(forceUpdateLEDs),
+                               [](const auto& i) { return PHY_LED_PATH + i; });
 
         auto skipLEDs = json.value("skipLEDs", empty);
-        for (auto& member : skipLEDs)
-        {
-            skipUpdateLEDs.push_back(PHY_LED_PATH + member);
-        }
+        std::ranges::transform(skipLEDs, std::back_inserter(skipUpdateLEDs),
+                               [](const auto& i) { return PHY_LED_PATH + i; });
     }
     catch (const std::exception& e)
     {