clang-tidy: Enable modernize-use-override check
This check adds override (introduced in C++11) to overridden
virtual functions and removes virtual from those functions as it
is not required.
Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7ce6bf641dabf4d325a29a1b641e58beac6885bd
diff --git a/.clang-tidy b/.clang-tidy
index 92b9cc8..d1d47cd 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -222,6 +222,7 @@
modernize-use-equals-default,
modernize-use-equals-delete,
modernize-use-noexcept,
+modernize-use-override,
modernize-use-transparent-functors,
modernize-use-uncaught-exceptions,
modernize-use-using'
diff --git a/manager/group.hpp b/manager/group.hpp
index 014fea6..2c33445 100644
--- a/manager/group.hpp
+++ b/manager/group.hpp
@@ -24,7 +24,7 @@
{
public:
Group() = delete;
- ~Group() = default;
+ ~Group() override = default;
Group(const Group&) = delete;
Group& operator=(const Group&) = delete;
Group(Group&&) = delete;
diff --git a/test/utest-group-priority.cpp b/test/utest-group-priority.cpp
index 73b3747..f47e5f2 100644
--- a/test/utest-group-priority.cpp
+++ b/test/utest-group-priority.cpp
@@ -17,7 +17,7 @@
{
// Nothing here
}
- ~LedTest() = default;
+ ~LedTest() override = default;
};
static void assertMap(std::map<LedName, Layout::LedAction> map,
diff --git a/test/utest.cpp b/test/utest.cpp
index 361e9c7..5f62f25 100644
--- a/test/utest.cpp
+++ b/test/utest.cpp
@@ -16,7 +16,7 @@
{
// Nothing here
}
- ~LedTest() = default;
+ ~LedTest() override = default;
};
/** @brief Assert Single LED to On */