commit f05925599f7ad2b07e326eb3413a488ce21bd1c6
author George Liu <liuxiwei@ieisystem.com> Fri Aug 23 09:46:17 2024 +0800
committer George Liu <liuxiwei@ieisystem.com> Wed Aug 28 09:36:02 2024 +0800
tree b6be0a7b801613e8f55f6db6eb5be662b90d4a2b
parent b6da78887c6906d9a07b9142e66f2ba7ff582449

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6efe76666f75fb4f65621796466d9347cea25d01

utils.cpp

diff --git a/utils.cpp b/utils.cpp
index a2a72cb..1da9602 100644
--- a/utils.cpp
+++ b/utils.cpp
@@ -11,7 +11,7 @@
 
 // Get service name
 std::string DBusHandler::getService(const std::string& path,
-                                    const std::string& interface) const
+                                    const std::string& interface)
 {
     using InterfaceList = std::vector<std::string>;
     std::unordered_map<std::string, std::vector<std::string>> mapperResponse;
@@ -38,7 +38,7 @@
 
 // Get all properties
 PropertyMap DBusHandler::getAllProperties(const std::string& objectPath,
-                                          const std::string& interface) const
+                                          const std::string& interface)
 {
     PropertyMap properties;
 
@@ -62,7 +62,7 @@
 // Get the property name
 PropertyValue DBusHandler::getProperty(const std::string& objectPath,
                                        const std::string& interface,
-                                       const std::string& propertyName) const
+                                       const std::string& propertyName)
 {
     PropertyValue value{};
 
@@ -86,7 +86,7 @@
 // Set property
 void DBusHandler::setProperty(
     const std::string& objectPath, const std::string& interface,
-    const std::string& propertyName, const PropertyValue& value) const
+    const std::string& propertyName, const PropertyValue& value)
 {
     auto& bus = DBusHandler::getBus();
     auto service = getService(objectPath, interface);
@@ -103,7 +103,7 @@
 }
 
 std::vector<std::string> DBusHandler::getSubTreePaths(
-    const std::string& objectPath, const std::string& interface) const
+    const std::string& objectPath, const std::string& interface)
 {
     std::vector<std::string> paths;