commit f05925599f7ad2b07e326eb3413a488ce21bd1c6
author George Liu <liuxiwei@ieisystem.com> Fri Aug 23 09:46:17 2024 +0800
committer George Liu <liuxiwei@ieisystem.com> Wed Aug 28 09:36:02 2024 +0800
tree b6be0a7b801613e8f55f6db6eb5be662b90d4a2b
parent b6da78887c6906d9a07b9142e66f2ba7ff582449

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6efe76666f75fb4f65621796466d9347cea25d01

utils.hpp

diff --git a/utils.hpp b/utils.hpp
index cd79fd5..456188a 100644
--- a/utils.hpp
+++ b/utils.hpp
@@ -52,8 +52,8 @@
      *  @return std::string  -  the D-Bus service name
      *
      */
-    std::string getService(const std::string& path,
-                           const std::string& interface) const;
+    static std::string getService(const std::string& path,
+                                  const std::string& interface);
 
     /** @brief Get All properties
      *
@@ -64,8 +64,8 @@
      *
      *  @throw sdbusplus::exception_t when it fails
      */
-    PropertyMap getAllProperties(const std::string& objectPath,
-                                 const std::string& interface) const;
+    static PropertyMap getAllProperties(const std::string& objectPath,
+                                        const std::string& interface);
 
     /** @brief Get property(type: variant)
      *
@@ -77,9 +77,9 @@
      *
      *  @throw sdbusplus::exception_t when it fails
      */
-    PropertyValue getProperty(const std::string& objectPath,
-                              const std::string& interface,
-                              const std::string& propertyName) const;
+    static PropertyValue getProperty(const std::string& objectPath,
+                                     const std::string& interface,
+                                     const std::string& propertyName);
 
     /** @brief Set D-Bus property
      *
@@ -90,10 +90,10 @@
      *
      *  @throw sdbusplus::exception_t when it fails
      */
-    void setProperty(const std::string& objectPath,
-                     const std::string& interface,
-                     const std::string& propertyName,
-                     const PropertyValue& value) const;
+    static void setProperty(const std::string& objectPath,
+                            const std::string& interface,
+                            const std::string& propertyName,
+                            const PropertyValue& value);
 
     /** @brief Get sub tree paths by the path and interface of the DBus.
      *
@@ -102,8 +102,8 @@
      *
      *  @return std::vector<std::string> vector of subtree paths
      */
-    std::vector<std::string> getSubTreePaths(
-        const std::string& objectPath, const std::string& interface) const;
+    static std::vector<std::string> getSubTreePaths(
+        const std::string& objectPath, const std::string& interface);
 };
 
 } // namespace utils