commit fecdd4dda1cc77eeed0db7ef835a061f3786642a
author Konstantin Aladyshev <aladyshev22@gmail.com> Fri Feb 07 12:28:19 2025 +0300
committer Konstantin Aladyshev <aladyshev22@gmail.com> Fri Feb 07 13:25:59 2025 +0300
tree 64d70ffe932b378f2e44564c67f47251bb5b0dee
parent 6fd9eea5fdb3fe8c1aea2d549af553b11dd2be4f

Fix clang-tidy errors

Change-Id: Iba8d2a18bb0ea3acd2b963e565a7e3020055cfc0
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

fault-monitor/operational-status-monitor.cpp

diff --git a/fault-monitor/operational-status-monitor.cpp b/fault-monitor/operational-status-monitor.cpp
index 10299f7..fb0ddad 100644
--- a/fault-monitor/operational-status-monitor.cpp
+++ b/fault-monitor/operational-status-monitor.cpp
@@ -30,7 +30,7 @@
     if (it != properties.end())
     {
         const bool* value = std::get_if<bool>(&it->second);
-        if (!value)
+        if (value == nullptr)
         {
             lg2::error(
                 "Failed to get the Functional property, INVENTORY_PATH = {PATH}",
@@ -56,7 +56,7 @@
 }
 
 std::vector<std::string>
-    Monitor::getLedGroupPaths(const std::string& inventoryPath) const
+    Monitor::getLedGroupPaths(const std::string& inventoryPath)
 {
     // Get endpoints from fType
     std::string faultLedAssociation = inventoryPath + "/fault_identifying";
@@ -68,9 +68,9 @@
 
     try
     {
-        endpoint = dBusHandler.getProperty(faultLedAssociation,
-                                           "xyz.openbmc_project.Association",
-                                           "endpoints");
+        endpoint = phosphor::led::utils::DBusHandler::getProperty(
+            faultLedAssociation, "xyz.openbmc_project.Association",
+            "endpoints");
     }
     catch (const sdbusplus::exception_t& e)
     {
@@ -95,8 +95,9 @@
             // false Call "Group Asserted --> false" if the value of Functional
             // is true
             PropertyValue assertedValue{!value};
-            dBusHandler.setProperty(path, "xyz.openbmc_project.Led.Group",
-                                    "Asserted", assertedValue);
+            phosphor::led::utils::DBusHandler::setProperty(
+                path, "xyz.openbmc_project.Led.Group", "Asserted",
+                assertedValue);
         }
         catch (const sdbusplus::exception_t& e)
         {

fault-monitor/operational-status-monitor.hpp

diff --git a/fault-monitor/operational-status-monitor.hpp b/fault-monitor/operational-status-monitor.hpp
index 751b970..65d3d9b 100644
--- a/fault-monitor/operational-status-monitor.hpp
+++ b/fault-monitor/operational-status-monitor.hpp
@@ -69,7 +69,7 @@
      *
      * @param[in] msg - The D-Bus message contents
      */
-    void matchHandler(sdbusplus::message_t& msg);
+    static void matchHandler(sdbusplus::message_t& msg);
 
     /**
      * @brief From the Inventory D-Bus object, obtains the associated LED group
@@ -79,8 +79,8 @@
      *
      * @return std::vector<std::string> - Vector of LED Group D-Bus object paths
      */
-    std::vector<std::string>
-        getLedGroupPaths(const std::string& inventoryPath) const;
+    static std::vector<std::string>
+        getLedGroupPaths(const std::string& inventoryPath);
 
     /**
      * @brief Update the Asserted property of the LED Group Manager.
@@ -88,8 +88,8 @@
      * @param[in] ledGroupPaths   - LED Group D-Bus object Paths
      * @param[in] value           - The Asserted property value, True / False
      */
-    void updateAssertedProperty(const std::vector<std::string>& ledGroupPaths,
-                                bool value);
+    static void updateAssertedProperty(
+        const std::vector<std::string>& ledGroupPaths, bool value);
 };
 } // namespace monitor
 } // namespace status