test: sysfs: Fix several clang-tidy warnings
* cppcoreguidelines-avoid-c-arrays
* cppcoreguidelines-pro-bounds-array-to-pointer-decay
* readability-implicit-bool-conversion
```
../test/sysfs.cpp:42:9: error: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,-warnings-as-errors]
char buffer[MAXPATHLEN] = {0};
^
../test/sysfs.cpp:44:17: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
strncpy(buffer, tmplt, sizeof(buffer) - 1);
^
../test/sysfs.cpp:45:29: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
char* dir = mkdtemp(buffer);
^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../test/sysfs.cpp:46:14: error: implicit conversion 'char *' -> bool [readability-implicit-bool-conversion,-warnings-as-errors]
if (!dir)
~^
== nullptr
```
Change-Id: Iab99b6551a51d83664c3f37df49f39f606614a7c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
diff --git a/test/sysfs.cpp b/test/sysfs.cpp
index 4bf49d3..444d8b3 100644
--- a/test/sysfs.cpp
+++ b/test/sysfs.cpp
@@ -39,11 +39,11 @@
static FakeSysfsLed create()
{
static constexpr auto tmplt = "/tmp/FakeSysfsLed.XXXXXX";
- char buffer[MAXPATHLEN] = {0};
+ std::array<char, MAXPATHLEN> buffer = {0};
- strncpy(buffer, tmplt, sizeof(buffer) - 1);
- char* dir = mkdtemp(buffer);
- if (!dir)
+ strncpy(buffer.data(), tmplt, buffer.size() - 1);
+ char* dir = mkdtemp(buffer.data());
+ if (dir == nullptr)
throw std::system_error(errno, std::system_category());
return FakeSysfsLed(fs::path(dir));