tree 23113807d01cc730dd095e6628d8b4c21eda8480
parent b934a857f01f6eec29ad009068fc4fcac221b02e
author Andrew Jeffery <andrew@aj.id.au> 1675673068 +1030
committer Andrew Jeffery <andrew@aj.id.au> 1675818007 +1030

test: sysfs: Fix several clang-tidy warnings

* cppcoreguidelines-avoid-c-arrays
* cppcoreguidelines-pro-bounds-array-to-pointer-decay
* readability-implicit-bool-conversion

```
../test/sysfs.cpp:42:9: error: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,-warnings-as-errors]
        char buffer[MAXPATHLEN] = {0};
        ^
../test/sysfs.cpp:44:17: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
        strncpy(buffer, tmplt, sizeof(buffer) - 1);
                ^
../test/sysfs.cpp:45:29: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
        char* dir = mkdtemp(buffer);
                            ^
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../test/sysfs.cpp:46:14: error: implicit conversion 'char *' -> bool [readability-implicit-bool-conversion,-warnings-as-errors]
        if (!dir)
            ~^
                 == nullptr
```

Change-Id: Iab99b6551a51d83664c3f37df49f39f606614a7c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>